Skip to content

Added init step for ovm node #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
K-Ho merged 1 commit into from
Sep 2, 2020
Merged

Added init step for ovm node #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ovm-toolchain/src/buidler-plugins/buidler-ovm-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ extendEnvironment(async (bre) => {
stateManager: vm.stateManager,
emGasLimit: gasLimit,
})
await ovm.init()

@karlfloersch karlfloersch Sep 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is so that we don't do that init step during the Synthetix tests & break snapshotting -- is that right?

@K-Ho K-Ho Sep 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @kfichter mentioned this was to ensure the Execution manager state is correctly initialized, which was messing with timestamps?

node['_vm' as any] = ovm

// Hijack the gas estimation function.
Expand Down