Skip to content

Comments

Added init step for ovm node#244

Merged
K-Ho merged 1 commit intomasterfrom
patch/ovm-toolchain/buidler-node
Sep 2, 2020
Merged

Added init step for ovm node#244
K-Ho merged 1 commit intomasterfrom
patch/ovm-toolchain/buidler-node

Conversation

@K-Ho
Copy link
Contributor

@K-Ho K-Ho commented Sep 1, 2020

Description

Patch to fix the ovm node for synthetix tests

Questions

Metadata

Fixes

  • Fixes

Contributing Agreement

Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stateManager: vm.stateManager,
emGasLimit: gasLimit,
})
await ovm.init()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is so that we don't do that init step during the Synthetix tests & break snapshotting -- is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @kfichter mentioned this was to ensure the Execution manager state is correctly initialized, which was messing with timestamps?

@K-Ho K-Ho merged commit 5fbe406 into master Sep 2, 2020
@gakonst gakonst deleted the patch/ovm-toolchain/buidler-node branch March 18, 2021 15:02
theochap pushed a commit that referenced this pull request Jan 15, 2026
<!--
Thank you for your Pull Request. Please provide a description above and
review
the requirements below.

Bug fixes and new features should include tests.

Contributors guide:
https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md

The contributors guide includes instructions for running rustfmt and
building the
documentation.
-->

<!-- ** Please select "Allow edits from maintainers" in the PR Options
** -->

## Motivation

Broken decoding for eip7702

## Solution

Adds conversion from u8 to `OpTxType::Eip7702`

## PR Checklist

- [ ] Added Tests
- [ ] Added Documentation
- [ ] Breaking changes
emhane pushed a commit that referenced this pull request Feb 4, 2026
emhane pushed a commit that referenced this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants