Merged
Conversation
The labeler wasn't applying `C-Protocol-Critical` labels correctly. I misinterpreted how the `any` rule was supposed to work.
|
Inphi
approved these changes
Apr 5, 2022
Contributor
Inphi
left a comment
There was a problem hiding this comment.
hmm yeah, the docs are kinda confusing on its usage.
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
tynes
approved these changes
Apr 6, 2022
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The labeler wasn't applying
C-Protocol-Criticallabels correctly. I misinterpreted how theanyrule was supposed to work.