Conversation
🦋 Changeset detectedLatest commit: 6863a69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mslipper
left a comment
There was a problem hiding this comment.
What do you think of removing the ability to update the scalar from the other script? Can have it raise an error if the scalar is passed in directing users to use this instead.
I don't see much of a need to brick the usage of the other script, there are no plans to alter the |
|
I'll update the functionality so its the same as the hardhat task |
The idea is to make it clear which script is canonical, so we don't have to maintain two ways of doing the same thing. |
4595ed2 to
5cb9a55
Compare
2f4194e to
78f63fb
Compare
I've deleted the old script now |
Create a simple script that can set the config for the `OVM_GasPriceOracle` using `cast`. Using the `hardhat` task requires 4gb+ of memory when running. Also remove the `set-l2-gasprice` hardhat task that does the same functionality
78f63fb to
9a59d09
Compare
|
Now the script can be used in "view only" mode by not passing a key |
Now that the script is 1:1 with functionality of the other script, I have deleted the other script |
|
@mergify refresh |
✅ Pull request refreshedHey, I reacted but my real name is @Mergifyio |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Create a simple script that can set the config for the `OVM_GasPriceOracle` using `cast`. Using the `hardhat` task requires 4gb+ of memory when running. Also remove the `set-l2-gasprice` hardhat task that does the same functionality Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…ncer config (#2425) ## Description Fix incorrect unsafe payload signature. Add a new large kona sequencer kurtosis configuration. Closes the sequencer MVP
Description
Create a simple script to set the scalar
in the
OVM_GasPriceOracleusingcastas using the
hardhattask requires 4gb+of memory when running.