Skip to content

contracts: gas oracle script#2425

Merged
mergify[bot] merged 2 commits intodevelopfrom
feat/cast-set-scalar
Apr 5, 2022
Merged

contracts: gas oracle script#2425
mergify[bot] merged 2 commits intodevelopfrom
feat/cast-set-scalar

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Apr 5, 2022

Description

Create a simple script to set the scalar
in the OVM_GasPriceOracle using cast
as using the hardhat task requires 4gb+
of memory when running.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022

🦋 Changeset detected

Latest commit: 6863a69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/sdk Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of removing the ability to update the scalar from the other script? Can have it raise an error if the scalar is passed in directing users to use this instead.

@tynes
Copy link
Contributor Author

tynes commented Apr 5, 2022

What do you think of removing the ability to update the scalar from the other script? Can have it raise an error if the scalar is passed in directing users to use this instead.

I don't see much of a need to brick the usage of the other script, there are no plans to alter the OVM_GasPriceOracle so there is no risk that it becomes stale, the code will all be deleted post bedrock

@tynes
Copy link
Contributor Author

tynes commented Apr 5, 2022

I'll update the functionality so its the same as the hardhat task

@mslipper
Copy link
Contributor

mslipper commented Apr 5, 2022

I don't see much of a need to brick the usage of the other script, there are no plans to alter the OVM_GasPriceOracle so there is no risk that it becomes stale, the code will all be deleted post bedrock

The idea is to make it clear which script is canonical, so we don't have to maintain two ways of doing the same thing.

@mergify mergify bot requested a review from Inphi April 5, 2022 19:49
@tynes tynes force-pushed the feat/cast-set-scalar branch from 4595ed2 to 5cb9a55 Compare April 5, 2022 19:53
@tynes tynes force-pushed the feat/cast-set-scalar branch 3 times, most recently from 2f4194e to 78f63fb Compare April 5, 2022 19:58
@tynes
Copy link
Contributor Author

tynes commented Apr 5, 2022

I don't see much of a need to brick the usage of the other script, there are no plans to alter the OVM_GasPriceOracle so there is no risk that it becomes stale, the code will all be deleted post bedrock

The idea is to make it clear which script is canonical, so we don't have to maintain two ways of doing the same thing.

I've deleted the old script now

Create a simple script that can set the
config for the  `OVM_GasPriceOracle` using `cast`.
Using the `hardhat` task requires 4gb+
of memory when running.

Also remove the `set-l2-gasprice` hardhat
task that does the same functionality
@tynes tynes force-pushed the feat/cast-set-scalar branch from 78f63fb to 9a59d09 Compare April 5, 2022 20:04
@tynes
Copy link
Contributor Author

tynes commented Apr 5, 2022

Now the script can be used in "view only" mode by not passing a key

@tynes tynes changed the title contracts: set scalar script contracts: gas oracle script Apr 5, 2022
@tynes
Copy link
Contributor Author

tynes commented Apr 5, 2022

I don't see much of a need to brick the usage of the other script, there are no plans to alter the OVM_GasPriceOracle so there is no risk that it becomes stale, the code will all be deleted post bedrock

The idea is to make it clear which script is canonical, so we don't have to maintain two ways of doing the same thing.

Now that the script is 1:1 with functionality of the other script, I have deleted the other script

@mergify mergify bot requested a review from Inphi April 5, 2022 22:01
@mslipper
Copy link
Contributor

mslipper commented Apr 5, 2022

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

refresh

✅ Pull request refreshed

Hey, I reacted but my real name is @Mergifyio

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 5818dec into develop Apr 5, 2022
@mergify mergify bot deleted the feat/cast-set-scalar branch April 5, 2022 22:26
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
Create a simple script that can set the
config for the  `OVM_GasPriceOracle` using `cast`.
Using the `hardhat` task requires 4gb+
of memory when running.

Also remove the `set-l2-gasprice` hardhat
task that does the same functionality

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap added a commit that referenced this pull request Dec 10, 2025
…ncer config (#2425)

## Description

Fix incorrect unsafe payload signature. Add a new large kona sequencer
kurtosis configuration. Closes the sequencer MVP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants