Skip to content

ci: Add teleportr release, fix indexer canary#2402

Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/teleportr-builds
Apr 4, 2022
Merged

ci: Add teleportr release, fix indexer canary#2402
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/teleportr-builds

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Apr 4, 2022

Teleportr was getting released on GitHub, but not pushed to Docker Hub. The indexer's canary builds were pushing batch-submitter-service images, which was incorrect.

Teleportr was getting released on GitHub, but not pushed to Docker Hub. The indexer's canary builds were pushing `batch-submitter-service` images, which was incorrect.
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

⚠️ No Changeset found

Latest commit: f4f9519

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from smartcontracts and tynes April 4, 2022 05:11
@mslipper mslipper requested review from Inphi and cfromknecht and removed request for smartcontracts and tynes April 4, 2022 05:12
@mergify mergify bot requested review from smartcontracts and tynes April 4, 2022 05:12
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we can automatically generate these yml files. It's a lot of duplicated content.

@tynes
Copy link
Contributor

tynes commented Apr 4, 2022

LGTM. I wonder if we can automatically generate these yml files. It's a lot of duplicated content.

Maybe we can refactor it to use a for loop? We run into a lot of bugs when copying the boilerplate here

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@tynes
Copy link
Contributor

tynes commented Apr 4, 2022

Flaky P2P tests:

--- FAIL: TestBoundedForkedSync64Fast (0.27s)
    downloader_test.go:681: failed to synchronise blocks: retrieved hash chain is invalid
--- FAIL: TestBoundedForkedSync63Fast (0.59s)
    downloader_test.go:681: failed to synchronise blocks: retrieved hash chain is invalid

Rerunning them now. These tests also sometimes failed on github actions, they can be skipped without it being a problem because we do not use the p2p network and we also do not use the reorg code. I don't feel super comfortable continuing to skip tests but we will be deprecating this codebase soon enough and there are no more large expected changes for it planned

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 31300f7 into ethereum-optimism:develop Apr 4, 2022
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
Teleportr was getting released on GitHub, but not pushed to Docker Hub. The indexer's canary builds were pushing `batch-submitter-service` images, which was incorrect.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
theochap pushed a commit that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants