Skip to content

tasks: compute calldata cost diff in fetch-batches#2381

Merged
tynes merged 1 commit intodevelopfrom
feat/gasusage-compression-ratio
Apr 28, 2022
Merged

tasks: compute calldata cost diff in fetch-batches#2381
tynes merged 1 commit intodevelopfrom
feat/gasusage-compression-ratio

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Mar 30, 2022

Description

Compute the calldata cost diff in the contracts packages
fetch-batches hardhat task.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

🦋 Changeset detected

Latest commit: 5cb3a5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@eth-optimism/core-utils Patch
@eth-optimism/common-ts Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-core-utils Area: packages/core-utils labels Mar 30, 2022
@tynes tynes force-pushed the feat/gasusage-compression-ratio branch from 9d15a45 to 8701579 Compare March 31, 2022 16:24
@mergify mergify bot requested review from cfromknecht and mslipper March 31, 2022 19:03
@mslipper mslipper force-pushed the feat/gasusage-compression-ratio branch from 8701579 to c8c5834 Compare March 31, 2022 19:03
@tynes tynes force-pushed the feat/gasusage-compression-ratio branch 2 times, most recently from be216e7 to bb40497 Compare March 31, 2022 19:31
@mergify mergify bot requested a review from tuxcanfly April 4, 2022 18:46
@cfromknecht
Copy link
Contributor

@tynes I think this is ready to go apart from @smartcontracts comments!

Compute the calldata cost diff in the contracts packages
`fetch-batches` hardhat task.
@tynes tynes force-pushed the feat/gasusage-compression-ratio branch from bb40497 to 5cb3a5f Compare April 13, 2022 19:12
@tynes
Copy link
Contributor Author

tynes commented Apr 13, 2022

@smartcontracts I added a docstring + basic tests

@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 28, 2022
@tynes tynes removed the Stale label Apr 28, 2022
@tynes tynes merged commit 8ac47db into develop Apr 28, 2022
@tynes tynes deleted the feat/gasusage-compression-ratio branch April 28, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants