Skip to content

deps: update l2geth-exporter to use go-ethereum v1.10.16#2354

Merged
mslipper merged 1 commit intodevelopfrom
deps/l2geth-exporter
Mar 23, 2022
Merged

deps: update l2geth-exporter to use go-ethereum v1.10.16#2354
mslipper merged 1 commit intodevelopfrom
deps/l2geth-exporter

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Mar 22, 2022

Description
Updates go-ethereum to fix the http2 error in the rpc client

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2022

🦋 Changeset detected

Latest commit: 2f2eaa4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth-exporter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #2354 (2f2eaa4) into develop (d4de0cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2354   +/-   ##
========================================
  Coverage    80.14%   80.14%           
========================================
  Files           77       77           
  Lines         2458     2458           
  Branches       450      450           
========================================
  Hits          1970     1970           
  Misses         488      488           
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4de0cf...2f2eaa4. Read the comment docs.

'@eth-optimism/l2geth-exporter': patch
---

Bump to go-ethereum v1.10.16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a standard version we're using? Any reason not to go to 1.17/18?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the minimum version we're using everywhere else. 1.18 is latest, but contains the new generics code and we should wait a bit before adopting it.

@mslipper mslipper merged commit bb75af3 into develop Mar 23, 2022
@mslipper mslipper deleted the deps/l2geth-exporter branch March 23, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants