fix(rhc): fix bug in healthcheck dockerfile#2352
Merged
smartcontracts merged 4 commits intodevelopfrom Mar 23, 2022
Merged
Conversation
smartcontracts
requested review from
mslipper,
optimisticben and
tynes
as code owners
🦋 Changeset detectedLatest commit: c50cafa The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2352 +/- ##
========================================
Coverage 80.14% 80.14%
========================================
Files 77 77
Lines 2458 2458
Branches 450 450
========================================
Hits 1970 1970
Misses 488 488
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tynes
reviewed
Mar 22, 2022
smartcontracts
force-pushed
the
sc/fix-rhc-docker
branch
from
472df8f to
9b6512c
Compare
smartcontracts
commented
Mar 22, 2022
| }, {}) as TMetrics | ||
|
|
||
| // Create the metrics server. | ||
| this.metricsRegistry = prometheus.register |
Contributor
Author
There was a problem hiding this comment.
Whoops. I forgot to expose the metrics at all.
github-actions
bot
added
M-ci
Fixes a bug in the replica-healthcheck dockerfile. Also includes replica-healthcheck as part of the ops setup by default to make this stuff easier to catch and debug in the future. We will likely still want to add integration tests that query the metrics defined in the replica-healthcheck to confirm that everything is working as expected.
Updates the replica-healthcheck service to cleanly catch connection failures in the target and reference nodes. When a failure is detected, a metric will be incremented and the failure will be logged.
Adds a single simple test to confirm that the healthcheck metrics server is running. If the server is not running then the healthcheck server likely did not start correctly and there might be an issue in the docker container.
smartcontracts
force-pushed
the
sc/fix-rhc-docker
branch
from
db8e426 to
c50cafa
Compare
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the replica-healthcheck dockerfile. Also includes
replica-healthcheck as part of the ops setup by default to make this
stuff easier to catch and debug in the future. We will likely still want
to add integration tests that query the metrics defined in the
replica-healthcheck to confirm that everything is working as expected.
Fixes #2351