Skip to content

minor teleportr API fixes#2326

Merged
mslipper merged 3 commits intoethereum-optimism:developfrom
cfromknecht:teleportr-api-fixes
Mar 14, 2022
Merged

minor teleportr API fixes#2326
mslipper merged 3 commits intoethereum-optimism:developfrom
cfromknecht:teleportr-api-fixes

Conversation

@cfromknecht
Copy link
Contributor

@cfromknecht cfromknecht commented Mar 14, 2022

Description
Addresses some minor fixes for issues discovered in Kovan deployment.

@cfromknecht
fix: teleportr enable-ssl should use "require"
7bcf88e
@cfromknecht
fix: small bugs in teleportr API server
cbf1ff4 
This commit fixes:
 * A bug in /status where is_available always returns false.
 * A bug in /track where the "teleport" key was incorrectly capitalized.
 * A bug in /track and /history where disbursements were never
   populated, also changes the behavior to show null when the
   disubrsement has not been processed.
@cfromknecht
feat: add db.LoadTeleport* tests
cf45bc8
@cfromknecht cfromknecht requested a review from mslipper as a code owner March 14, 2022 20:25
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022

⚠️ No Changeset found

Latest commit: cf45bc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cfromknecht cfromknecht changed the title Teleportr api fixes minor teleportr API fixes Mar 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022 •
edited
Loading

Codecov Report

Merging #2326 (cf45bc8) into develop (ccd9881) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2326   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files           77       77           
  Lines         2460     2460           
  Branches       450      450           
========================================
  Hits          1970     1970           
  Misses         490      490
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd9881...cf45bc8. Read the comment docs.

@mslipper mslipper merged commit dc53a3b into ethereum-optimism:develop Mar 14, 2022
@cfromknecht cfromknecht deleted the teleportr-api-fixes branch March 14, 2022 23:34
theochap pushed a commit that referenced this pull request Dec 10, 2025
@dhyaniarun1993
chore(supervisor): grafana dashboard (#2326)
cf7a5ca 
Closes #2135

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cfromknecht @codecov-commenter @mslipper