Skip to content

go/teleportr contracts: Updates to support deploying Teleportr to Kovan#2321

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:feat/teleportr-kovan
Mar 22, 2022
Merged

go/teleportr contracts: Updates to support deploying Teleportr to Kovan#2321
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:feat/teleportr-kovan

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Mar 14, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7150efb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper mslipper force-pushed the feat/teleportr-kovan branch from 76654ef to 1df65b3 Compare March 14, 2022 04:52
@github-actions github-actions bot added the A-ops Area: ops label Mar 14, 2022
@mslipper mslipper force-pushed the feat/teleportr-kovan branch 5 times, most recently from 6d939a5 to f2276f8 Compare March 14, 2022 04:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022 •
edited
Loading

Codecov Report

Merging #2321 (7150efb) into develop (06d821b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2321   +/-   ##
========================================
  Coverage    80.14%   80.14%           
========================================
  Files           77       77           
  Lines         2458     2458           
  Branches       450      450           
========================================
  Hits          1970     1970           
  Misses         488      488
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d821b...7150efb. Read the comment docs.

@mslipper mslipper force-pushed the feat/teleportr-kovan branch 4 times, most recently from d1b3f0e to 7f92686 Compare March 14, 2022 07:41
cfromknecht
cfromknecht reviewed Mar 14, 2022
View reviewed changes
go/teleportr/drivers/disburser/driver.go
}
disbursements = append(disbursements, disbursement)
depositIDs = append(depositIDs, deposit.ID)
value = value.Add(value, deposit.Amount)
Copy link
Contributor

@cfromknecht cfromknecht Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

go/teleportr/teleportr.go
PollInterval: cfg.PollInterval,
ClearPendingTx: false,
L1Client: l1Client,
L1Client: l2Client,
Copy link
Contributor

@cfromknecht cfromknecht Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, note to self to rename L1Client to be more generic

@tynes
Copy link
Contributor

tynes commented Mar 14, 2022

I notice that the contracts are deployed, but there aren't any hardhat artifacts for them in packages/contracts/deployments

tynes
tynes reviewed Mar 14, 2022
View reviewed changes
elenadimitrova
elenadimitrova reviewed Mar 14, 2022
View reviewed changes
@cfromknecht cfromknecht force-pushed the feat/teleportr-kovan branch from 7f92686 to 2fc1b3d Compare March 14, 2022 20:28
tynes
tynes reviewed Mar 14, 2022
View reviewed changes
tynes
tynes reviewed Mar 14, 2022
View reviewed changes
@cfromknecht cfromknecht force-pushed the feat/teleportr-kovan branch from 2fc1b3d to e640245 Compare March 14, 2022 23:14
@maurelian maurelian removed the request for review from elenadimitrova March 15, 2022 13:12
@maurelian maurelian removed their request for review March 15, 2022 13:12
@mslipper mslipper force-pushed the feat/teleportr-kovan branch 4 times, most recently from 2ccea85 to 1b2b20a Compare March 20, 2022 05:56
@tynes
Copy link
Contributor

tynes commented Mar 21, 2022

I see there are artifacts now, good work. This generally looks good to me, just needs some linting

@mslipper mslipper force-pushed the feat/teleportr-kovan branch from 1b2b20a to fa90d4a Compare March 21, 2022 22:26
@mslipper mslipper force-pushed the feat/teleportr-kovan branch from fa90d4a to 7150efb Compare March 22, 2022 04:41
@mslipper mslipper merged commit d4de0cf into ethereum-optimism:develop Mar 22, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@PoulavBhowmick03
chore(bean/node): removed --l2-engine-kind from kona (#2321)
895a5a5 
Fixes #2317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

@optimisticben optimisticben Awaiting requested review from optimisticben

+2 more reviewers

@elenadimitrova elenadimitrova elenadimitrova left review comments

@cfromknecht cfromknecht cfromknecht left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ops Area: ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mslipper @codecov-commenter @tynes @elenadimitrova @cfromknecht