maint(dtl): remove unused L1DataTransportClient#2316
Conversation
🦋 Changeset detectedLatest commit: 075f4b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2316 +/- ##
========================================
Coverage 80.08% 80.08%
========================================
Files 77 77
Lines 2460 2460
Branches 450 450
========================================
Hits 1970 1970
Misses 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
While i agree that this should be a minor change, we usually saved minor changes for each new regenesis. We dont follow semver which is allowed because we are pre 1.0 |
Removes the unused L1DataTransportClient class which added extra dependencies but was not being used anywhere in the codebase. I also searched for usage of the class on GitHub and found no results. I think we can safely remove this because we haven't needed it for anything in over a year and we have other ways to get data out of the DTL when we need it.
smartcontracts
force-pushed
the
sc/remove-dtl-client
branch
from
2f151fc to
075f4b6
Compare
Updated to |
Fixes #2316 --------- Co-authored-by: refcell <abigger87@gmail.com>
Fixes #2316 --------- Co-authored-by: refcell <abigger87@gmail.com>
4 participants
Description
Removes the unused L1DataTransportClient class which added extra
dependencies but was not being used anywhere in the codebase. I also
searched for usage of the class on GitHub and found no results. I think
we can safely remove this because we haven't needed it for anything in
over a year and we have other ways to get data out of the DTL when we
need it.