Skip to content

Set the message-relayer package to private#2313

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
nickmzero:set-message-relayer-package-private
Mar 11, 2022
Merged

Set the message-relayer package to private#2313
mslipper merged 1 commit intoethereum-optimism:developfrom
nickmzero:set-message-relayer-package-private

Conversation

@nickmzero
Copy link
Contributor

@nickmzero nickmzero commented Mar 11, 2022

Tiny pr, marking the message-relayer package as private.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2022

⚠️ No Changeset found

Latest commit: aa9a7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #2313 (aa9a7d3) into develop (f50d1c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2313   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files           77       77           
  Lines         2460     2460           
  Branches       450      450           
========================================
  Hits          1970     1970           
  Misses         490      490           
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50d1c4...aa9a7d3. Read the comment docs.

Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thank you! 🙏

For other reviewers: the reason this is being done can be found in #2312. I don't believe this requires a changeset since it doesn't really change anything, but we could consider cutting a major release here to distinguish it from previous versions.

@mslipper mslipper merged commit 916be60 into ethereum-optimism:develop Mar 11, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Plumbs in the reset request channel from #2312 into the
`SequencerActor`, and sends a reset request if there is a `Reset` error
during attributes building.

closes #2305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "private" attribute to message-relayer package.json

4 participants