Skip to content

Comments

fix: Use consistent style/naming for Geth, L2Geth#2310

Merged
maurelian merged 1 commit intomasterfrom
maurelian/post-mortem-fix
Mar 10, 2022
Merged

fix: Use consistent style/naming for Geth, L2Geth#2310
maurelian merged 1 commit intomasterfrom
maurelian/post-mortem-fix

Conversation

@maurelian
Copy link
Contributor

This edit is meant to remove any ambiguity about which instance is being referred to, and also standardizes on the
spacing and capitalization used for Geth and L2Geth

This edit is meant to remove any ambiguity about which instance is being referred to, and also standardizes on the 
spacing and capitalization used for Geth and L2Geth
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2022

⚠️ No Changeset found

Latest commit: 2f4be06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #2310 (2f4be06) into master (c74649c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2310   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          77       77           
  Lines        2460     2460           
  Branches      450      450           
=======================================
  Hits         1970     1970           
  Misses        490      490           
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74649c...2f4be06. Read the comment docs.

@maurelian maurelian merged commit 83a45f9 into master Mar 10, 2022
@maurelian maurelian deleted the maurelian/post-mortem-fix branch March 10, 2022 21:04
theochap added a commit that referenced this pull request Dec 10, 2025
…r pattern (#2310)

## Description

This PR refactors the sequencer module using the new builder pattern. In
particular this moves the process of building the initial sequencer
actor state inside the sequencer actor's `start` method.

@clabby for visibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants