Conversation
This commit adds all packages in the `go` directory to the changesets packages so that they don't need to be added individually. It also removes `specs` since that directory no longer exists.
|
mslipper
approved these changes
Mar 7, 2022
mslipper
requested changes
Mar 7, 2022
Collaborator
mslipper
left a comment
mslipper
left a comment
There was a problem hiding this comment.
For some reason it's running indexer unit tests in CI now? Those don't exist yet, so it's throwing an error.
Contributor
Author
This has been fixed, |
smartcontracts
approved these changes
Mar 7, 2022
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…he actor (#2271) ## Description First attempt to decouple channel handling from the individual actors. This PR merely refactors the `NodeActor` trait to add a `Context` associated type that gets passed to the `start` method in the trait. I think from here we can make the structure simpler by: - Refactoring the `process` private methods into separate methods. That should remove the extra arguments for the `EngineActor` - Abstracting the actor building process behind the `new` methods of the individual actors. In particular, split up the context using inbound/outbound associated types and define channels inside the actor's `new` methods.
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…ait (#2284) ## Description This PR builds up on the changes introduced by #2271 to simplify/unify further the structure of the node service crates. In particular this PR: - Adds two associated types to the `NodeActor` trait. `OutboundData` and `State` which are used to specify a new build method for the actor that aims to replace single calls of the `new` methods. The build method has the following signature: ``` fn build(initial_state: Self::State) -> (Self::OutboundData, Self); ``` - Takes out the output channels from the `ActorContext` back into the `Actor` struct. This allows to drastically reduce the number of arguments to provide to the `build` methods and remove the need to define channels inside the implementation of the `RollupNodeService` trait. Instead this is done inside the `NodeActor` themselves - Add an associated type to the `RollupNodeService` for each actor and call the build methods from the associated types. That will make it much easier to have a modular architecture where we can easily swap out components if needed ## Follow-ups Most of the heavy lifting is done in this PR, but I would like to do some quick follow-ups to refactor/simplify/improve the inner structure of actors even further. We should also think about which types we want to expose to the public api and try to cut down the number of public exports in our libraries.
theochap
added a commit
that referenced
this pull request
Jan 14, 2026
…ait (op-rs/kona#2284) ## Description This PR builds up on the changes introduced by #2271 to simplify/unify further the structure of the node service crates. In particular this PR: - Adds two associated types to the `NodeActor` trait. `OutboundData` and `State` which are used to specify a new build method for the actor that aims to replace single calls of the `new` methods. The build method has the following signature: ``` fn build(initial_state: Self::State) -> (Self::OutboundData, Self); ``` - Takes out the output channels from the `ActorContext` back into the `Actor` struct. This allows to drastically reduce the number of arguments to provide to the `build` methods and remove the need to define channels inside the implementation of the `RollupNodeService` trait. Instead this is done inside the `NodeActor` themselves - Add an associated type to the `RollupNodeService` for each actor and call the build methods from the associated types. That will make it much easier to have a modular architecture where we can easily swap out components if needed ## Follow-ups Most of the heavy lifting is done in this PR, but I would like to do some quick follow-ups to refactor/simplify/improve the inner structure of actors even further. We should also think about which types we want to expose to the public api and try to cut down the number of public exports in our libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds all packages in the
godirectoryto the changesets packages so that they don't need
to be added individually. It also removes
specssincethat directory no longer exists.