Skip to content

batch-submitter: Remove bad changeset, remove old build#2267

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:bugfix/remove-bad-changeset
Mar 7, 2022
Merged

batch-submitter: Remove bad changeset, remove old build#2267
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:bugfix/remove-bad-changeset

Conversation

@mslipper
Copy link
Contributor

@mslipper mslipper commented Mar 7, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2022

⚠️ No Changeset found

Latest commit: 48ac444

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper mslipper force-pushed the bugfix/remove-bad-changeset branch from a3a4965 to 17fa526 Compare March 7, 2022 06:36
@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work labels Mar 7, 2022
@mslipper mslipper force-pushed the bugfix/remove-bad-changeset branch from 17fa526 to 48ac444 Compare March 7, 2022 06:37
@mslipper mslipper changed the title batch-submitter: Remove bad changeset batch-submitter: Remove bad changeset, remove old build Mar 7, 2022
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #2267 (48ac444) into develop (f8b5803) will increase coverage by 19.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2267       +/-   ##
============================================
+ Coverage    80.08%   99.29%   +19.21%     
============================================
  Files           77       35       -42     
  Lines         2460     1130     -1330     
  Branches       450      158      -292     
============================================
- Hits          1970     1122      -848     
+ Misses         490        8      -482     
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils ?
data-transport-layer ?
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/l2-provider.ts
...layer/src/services/l1-ingestion/handlers/errors.ts
...ices/l1-ingestion/handlers/state-batch-appended.ts
packages/core-utils/src/common/index.ts
packages/sdk/hardhat.config.ts
packages/core-utils/src/optimism/batch-encoding.ts
.../src/services/l2-ingestion/handlers/transaction.ts
packages/core-utils/src/external/ethers/index.ts
packages/sdk/src/utils/index.ts
...ckages/data-transport-layer/src/utils/contracts.ts
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b5803...48ac444. Read the comment docs.

@mslipper mslipper merged commit e2be0f3 into ethereum-optimism:develop Mar 7, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Introduces `zepter` checks, with a configuration derived from
[`alloy`](https://github.com/alloy-rs/alloy).
[`zepter`](https://crates.io/crates/zepter) enforces correct feature
propagation and formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants