Skip to content

feat: indexer service to replace etherscan dependency#2266

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:feat/indexer-updates
Mar 7, 2022
Merged

feat: indexer service to replace etherscan dependency#2266
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:feat/indexer-updates

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Mar 7, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2022

⚠️ No Changeset found

Latest commit: 0838522

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper
Copy link
Collaborator Author

mslipper commented Mar 7, 2022

This PR was reviewed as part of #2001. Since I didn't want to force push to @tuxcanfly's fork, I closed the PR and reopened as this one. I'll merge this once the build goes green and @tuxcanfly approves.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #2266 (0838522) into develop (f8b5803) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2266   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files           77       77           
  Lines         2460     2460           
  Branches       450      450           
========================================
  Hits          1970     1970           
  Misses         490      490           
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b5803...0838522. Read the comment docs.

Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM.

@mslipper mslipper merged commit 4ddf98a into ethereum-optimism:develop Mar 7, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

This PR removes the `process` method from `NodeActor` trait to simplify
the structure of the `NodeActor`

Progress to #2176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants