cleanup(contracts): remove unused code#2263
cleanup(contracts): remove unused code#2263mslipper merged 1 commit intoethereum-optimism:developfrom tonykogias:remove-unused-function-contracts-package
Conversation
Removes functions and constants that are not used in the contracts package. Also removes export from interfaces that are not being imported.
🦋 Changeset detectedLatest commit: b6a4fa4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@smartcontracts As you can see from the changes I found a couple more things that are not being used anywhere in the module and removed I am not used to semantic versioning yet but I added it as a |
Codecov Report
@@ Coverage Diff @@
## develop #2263 +/- ##
========================================
Coverage 80.08% 80.08%
========================================
Files 77 77
Lines 2460 2460
Branches 450 450
========================================
Hits 1970 1970
Misses 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thank you! LGTM |
### Description The `setEcotone()` selector was incorrectly encoded as `22b908b3` in `kona-hardforks`. See [the op specs](https://specs.optimism.io/protocol/ecotone/derivation.html?highlight=setEcotone#gaspriceoracle-enable-ecotone). ``` cast sig "setEcotone()" 0x22b90ab3 ``` Adds tests to ensure that the selectors are correctly set.
3 participants
Removes functions and constants that are not used in the contracts
package. Also removes export from interfaces that are not being imported.
Metadata