Skip to content

feat: remove packages/batch-submitter#2254

Merged
mslipper merged 2 commits intoethereum-optimism:developfrom
cfromknecht:remove-ts-batch-submitter
Mar 4, 2022
Merged

feat: remove packages/batch-submitter#2254
mslipper merged 2 commits intoethereum-optimism:developfrom
cfromknecht:remove-ts-batch-submitter

Conversation

@cfromknecht
Copy link
Contributor

Description
Removes the Typescript batch submitter now that the Go version has successfully been deployed on mainnet.

Metadata

  • Fixes ENG-2020

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2022

⚠️ No Changeset found

Latest commit: 6b0d57a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-op-batcher Area: op-batcher M-ci Meta: ci related work A-ops Area: ops labels Mar 3, 2022
@cfromknecht cfromknecht force-pushed the remove-ts-batch-submitter branch from 2c40ad4 to d8e7463 Compare March 3, 2022 23:47
@cfromknecht cfromknecht force-pushed the remove-ts-batch-submitter branch from d8e7463 to 6b0d57a Compare March 3, 2022 23:53
@smartcontracts
Copy link
Contributor

throw-out-rage

Get rid of it!

@snario
Copy link
Contributor

snario commented Mar 4, 2022

Hoorah

@codecov-commenter
Copy link

Codecov Report

Merging #2254 (6b0d57a) into develop (aa726e8) will increase coverage by 6.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2254      +/-   ##
===========================================
+ Coverage    74.57%   80.96%   +6.38%     
===========================================
  Files           86       77       -9     
  Lines         2962     2432     -530     
  Branches       511      434      -77     
===========================================
- Hits          2209     1969     -240     
+ Misses         753      463     -290     
Flag Coverage Δ
batch-submitter ?
contracts 99.29% <ø> (+8.40%) ⬆️
core-utils 86.77% <ø> (-2.36%) ⬇️
data-transport-layer 49.72% <ø> (ø)
sdk 57.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-utils/src/optimism/batch-encoding.ts 89.30% <0.00%> (-5.05%) ⬇️
.../contracts/L1/messaging/L1CrossDomainMessenger.sol 98.38% <0.00%> (+1.61%) ⬆️
.../contracts/L1/rollup/CanonicalTransactionChain.sol 100.00% <0.00%> (+1.90%) ⬆️
...tracts/contracts/L1/messaging/L1StandardBridge.sol 100.00% <0.00%> (+2.94%) ⬆️
.../contracts/L2/messaging/L2CrossDomainMessenger.sol 96.42% <0.00%> (+3.57%) ⬆️
...tracts/contracts/L2/messaging/L2StandardBridge.sol 100.00% <0.00%> (+4.54%) ⬆️
...racts/contracts/libraries/utils/Lib_MerkleTree.sol 100.00% <0.00%> (+6.12%) ⬆️
...ontracts/contracts/libraries/rlp/Lib_RLPWriter.sol 100.00% <0.00%> (+6.15%) ⬆️
...contracts/contracts/libraries/utils/Lib_Buffer.sol 100.00% <0.00%> (+7.14%) ⬆️
...racts/contracts/L1/rollup/StateCommitmentChain.sol 100.00% <0.00%> (+12.50%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa726e8...6b0d57a. Read the comment docs.

@mslipper mslipper merged commit 1efebf1 into ethereum-optimism:develop Mar 4, 2022
@cfromknecht cfromknecht deleted the remove-ts-batch-submitter branch March 4, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-batcher Area: op-batcher A-ops Area: ops M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants