feat(sdk): add fn to wait for message status#2252
Merged
Conversation
🦋 Changeset detectedLatest commit: b66e313 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
force-pushed
the
sc/wait-for-status
branch
from
bfd580b to
9ac6e30
Compare
smartcontracts
force-pushed
the
sc/wait-for-status
branch
from
9ac6e30 to
b228c2f
Compare
Contributor
|
Generally looks good to me, but I don't know the codebase super well |
tynes
approved these changes
Mar 3, 2022
Adds a function to the SDK (waitForMessageStatus) which will wait until the status of a particular message matches the target status. waitForMessageStatus also handles certain special cases where different status messages are incompatible (e.g., the RELAYED and FAILED_L1_TO_L2_MESSAGE status for L1 to L2 messages). Useful to avoid including looping logic in your own application.
smartcontracts
force-pushed
the
sc/wait-for-status
branch
from
b228c2f to
b66e313
Compare
qbzzt
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a function to the SDK (waitForMessageStatus) which will wait until
the status of a particular message matches the target status.
waitForMessageStatus also handles certain special cases where different
status messages are incompatible (e.g., the RELAYED and
FAILED_L1_TO_L2_MESSAGE status for L1 to L2 messages). Useful to avoid
including looping logic in your own application.