Skip to content

feat(sdk): add approval fns to the SDK#2213

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-approvals
Feb 19, 2022
Merged

feat(sdk): add approval fns to the SDK#2213
smartcontracts merged 1 commit intodevelopfrom
sc/sdk-approvals

Conversation

@smartcontracts
Copy link
Contributor

Description
Adds functions to the SDK for handling token approvals to bridges.

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2022

🦋 Changeset detected

Latest commit: 0c54e60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #2213 (5079319) into develop (e0f7e5f) will decrease coverage by 0.76%.
The diff coverage is 12.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2213      +/-   ##
===========================================
- Coverage    73.35%   72.59%   -0.77%     
===========================================
  Files           84       84              
  Lines         2766     2795      +29     
  Branches       472      477       +5     
===========================================
  Hits          2029     2029              
- Misses         737      766      +29     
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 87.80% <ø> (ø)
data-transport-layer 36.89% <ø> (ø)
sdk 57.62% <12.12%> (-2.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/adapters/standard-bridge.ts 23.95% <0.00%> (-4.44%) ⬇️
packages/sdk/src/cross-chain-messenger.ts 69.85% <16.66%> (-2.15%) ⬇️
packages/sdk/src/adapters/eth-bridge.ts 50.00% <33.33%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f7e5f...5079319. Read the comment docs.

@github-actions github-actions bot added the A-pkg-sdk Area: packages/sdk label Feb 17, 2022
@smartcontracts smartcontracts merged commit 2400ffc into develop Feb 19, 2022
@smartcontracts smartcontracts deleted the sc/sdk-approvals branch February 19, 2022 20:52
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-sdk Area: packages/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants