Skip to content

fix: remove extra space in BSS metric names#2186

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:bss-fix-metric-name-space
Feb 9, 2022
Merged

fix: remove extra space in BSS metric names#2186
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:bss-fix-metric-name-space

Conversation

@cfromknecht
Copy link
Contributor

Description
Removes an extra space in the BSS metrics names that causes the service to die on startup.

Metadata

  • Fixes ENG-1954

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

🦋 Changeset detected

Latest commit: df98d13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/batch-submitter-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cfromknecht cfromknecht requested a review from mslipper February 9, 2022 19:16
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #2186 (df98d13) into develop (6c9b91d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2186   +/-   ##
========================================
  Coverage    70.57%   70.57%           
========================================
  Files           89       89           
  Lines         3028     3028           
  Branches       509      509           
========================================
  Hits          2137     2137           
  Misses         891      891           
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 62.08% <ø> (ø)
data-transport-layer 37.74% <ø> (ø)
message-relayer 70.86% <ø> (ø)
sdk 59.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9b91d...df98d13. Read the comment docs.

@mslipper mslipper merged commit e52c36f into ethereum-optimism:develop Feb 9, 2022
@cfromknecht cfromknecht deleted the bss-fix-metric-name-space branch February 15, 2022 22:33
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants