Skip to content

Remove some unused code#2133

Merged
tynes merged 3 commits intodevelopfrom
m/cleanup
Feb 5, 2022
Merged

Remove some unused code#2133
tynes merged 3 commits intodevelopfrom
m/cleanup

Conversation

@maurelian
Copy link
Contributor

Description

Some small changes:

  1. Removes an unused import
  2. Removes unused gas testing utils
  3. Formats an md document (this was just a result of running yarn lint in the root)

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2022

🦋 Changeset detected

Latest commit: 4710779

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/contracts Patch
@eth-optimism/batch-submitter Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #2133 (4710779) into develop (849ec8c) will increase coverage by 0.70%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2133      +/-   ##
===========================================
+ Coverage    72.96%   73.66%   +0.70%     
===========================================
  Files           85       67      -18     
  Lines         2918     2187     -731     
  Branches       496      327     -169     
===========================================
- Hits          2129     1611     -518     
+ Misses         789      576     -213     
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 37.74% <ø> (ø)
message-relayer ?
sdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontracts/libraries/bridge/Lib_CrossDomainUtils.sol 100.00% <ø> (ø)
packages/sdk/src/adapters/standard-bridge.ts
packages/message-relayer/src/relay-tx.ts
packages/sdk/src/utils/index.ts
packages/sdk/src/utils/coercion.ts
packages/message-relayer/hardhat.config.ts
packages/sdk/src/adapters/eth-bridge.ts
packages/sdk/src/utils/message-encoding.ts
packages/sdk/src/index.ts
packages/sdk/src/cross-chain-messenger.ts
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849ec8c...4710779. Read the comment docs.

@smartcontracts
Copy link
Contributor

Gotta love getting rid of code

@smartcontracts
Copy link
Contributor

@tynes tynes merged commit 855fc76 into develop Feb 5, 2022
@tynes tynes deleted the m/cleanup branch February 5, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants