Skip to content

Extract core BSS logic into bss-core package#2107

Merged
mslipper merged 3 commits intoethereum-optimism:developfrom
cfromknecht:bss-core
Feb 2, 2022
Merged

Extract core BSS logic into bss-core package#2107
mslipper merged 3 commits intoethereum-optimism:developfrom
cfromknecht:bss-core

Conversation

@cfromknecht
Copy link
Contributor

@cfromknecht cfromknecht commented Feb 1, 2022

Description
This PR extracts the reusable components of the batch-submitter into a separate bss-core package. Additionally, the driver configuration is now done outside of NewBatchSubmitter, which now just blindly runs a list of *bsscore.Services. The portions that remain in the batch-submitter package are:

  • proposer/sequencer drivers
  • ctc/scc bindings
  • flags, configuration
  • driver instantiation

With this refactor, the plan is to build our in house Teleportr service simply by defining a new driver and leveraging the existing work to productionize the components of the bss-core package.

NOTE: This is purely a code move, there are no behavioral changes to the batch submitter.

Metadata

  • Fixes ENG-1929

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

🦋 Changeset detected

Latest commit: d4c2e01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/batch-submitter-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #2107 (60bf985) into develop (2192846) will decrease coverage by 10.20%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2107       +/-   ##
============================================
- Coverage    82.83%   72.63%   -10.21%     
============================================
  Files           48       85       +37     
  Lines         1445     2872     +1427     
  Branches       216      469      +253     
============================================
+ Hits          1197     2086      +889     
- Misses         248      786      +538     
Flag Coverage Δ
batch-submitter 62.63% <ø> (?)
contracts 90.48% <ø> (ø)
core-utils 59.94% <ø> (ø)
data-transport-layer 37.74% <ø> (?)
message-relayer 70.86% <ø> (?)
sdk 68.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubmitter/src/batch-submitter/tx-batch-submitter.ts 46.07% <0.00%> (ø)
packages/sdk/src/adapters/index.ts 100.00% <0.00%> (ø)
...ices/l1-ingestion/handlers/transaction-enqueued.ts 53.84% <0.00%> (ø)
packages/sdk/src/utils/message-encoding.ts 100.00% <0.00%> (ø)
packages/sdk/src/interfaces/index.ts 100.00% <0.00%> (ø)
...ackages/batch-submitter/src/utils/tx-submission.ts 90.90% <0.00%> (ø)
...ices/l1-ingestion/handlers/state-batch-appended.ts 68.18% <0.00%> (ø)
packages/sdk/src/utils/coercion.ts 88.46% <0.00%> (ø)
packages/data-transport-layer/src/utils/common.ts 47.05% <0.00%> (ø)
packages/sdk/src/interfaces/types.ts 100.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2192846...60bf985. Read the comment docs.

@mslipper mslipper merged commit 933b26e into ethereum-optimism:develop Feb 2, 2022
cfromknecht added a commit to cfromknecht/optimism that referenced this pull request Feb 8, 2022
cfromknecht added a commit to cfromknecht/optimism that referenced this pull request Feb 8, 2022
cfromknecht added a commit to cfromknecht/optimism that referenced this pull request Feb 8, 2022
cfromknecht added a commit to cfromknecht/optimism that referenced this pull request Feb 8, 2022
cfromknecht added a commit to cfromknecht/optimism that referenced this pull request Feb 8, 2022
cfromknecht added a commit to cfromknecht/optimism that referenced this pull request Feb 9, 2022
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
### Description

Sets up the supervisor actor which will spawn and handle communication
to and from the supervisor as an external or in-process service.

Progress on #2107.
theochap pushed a commit that referenced this pull request Jan 14, 2026
### Description

Sets up the supervisor actor which will spawn and handle communication
to and from the supervisor as an external or in-process service.

Progress on #2107.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants