Closed
Conversation
smartcontracts
approved these changes
Aug 27, 2020
Contributor
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
LGTM. Left a few misc comments.
|
|
||
| function setStorage(bytes32 key, bytes32 value) public { | ||
| builtInStorage[key] = value; | ||
| bytes memory EMcalldata = abi.encodeWithSelector(bytes4(keccak256(bytes("ovmSSTORE()"))), key, value); |
Contributor
There was a problem hiding this comment.
Can we rename this to SimpleStorageOVM just to clarify the separation?
| * TESTS * | ||
| *********/ | ||
|
|
||
| describe.skip('Partial State Manager -- Storage Performance Testing Script', () => { |
Contributor
There was a problem hiding this comment.
Any reason why this is skipped right now?
| } | ||
| }) | ||
|
|
||
| it('setStorage', async () => { |
Contributor
There was a problem hiding this comment.
I think generally better to put each function into a separate describe() and then list out the cases within an it().
Contributor
|
Closing in favor of ethereum-optimism/contracts#71 |
Lredhdx
pushed a commit
to node-real/combo-optimism
that referenced
this pull request
Jun 17, 2024
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Alters the workflow triggers such that the `push` trigger only runs when the PR is merged into `main`, and the `pull_request` trigger is agnostic to the `type`. This prevents double-runs of CI workflows in the merge queue / upon PR creation.
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
emhane
pushed a commit
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a script to our tests that allows you to check out the PSM cost of
ovmSSTOREandovmSLOADunder various conditions.Questions
Metadata
Fixes
Contributing Agreement