This repository was archived by the owner on Apr 12, 2021. It is now read-only.
[WIP] State Manager Gas Consumption Script#71
Merged
Conversation
ben-chain
commented
Nov 19, 2020
Comment on lines
+24
to
+26
| gasBefore := gas() | ||
| success := call(gas(), _target, 0, calldataStart, calldataLength, 0, 0) | ||
| gasAfter := gas() |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure exactly how this overhead works, but presumably will need to subtract at minimum the cost of GAS + CALL`, and possibly more, to get this to be the value we consume in geth.
Collaborator
|
First pass looks good to me. Will do a more thorough review of all the test cases tomorrow just to double check that the paths are covered. 👍 I'll think on the figuring out how to get the exact gas cost. Maybe we can just debug and look at the opcodes between the gas recording points. |
| }) | ||
|
|
||
| describe('getContractStorage', () => { | ||
| // confirm with kelvin that this covers all cases |
smartcontracts
approved these changes
Nov 20, 2020
Collaborator
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
Looks good. I think this covers everything.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a little script which meters and prints the gas consumption of the
OVM_StateManagermethods under various conditions.Questions
Any cases I missed?
Metadata
Fixes
Contributing Agreement