Skip to content

fix(op-reth): propagate MDBX errors in DupSort cursor iterators instead of silently swallowing them #19604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theochap merged 1 commit into from
Mar 18, 2026
Merged

fix(op-reth): propagate MDBX errors in DupSort cursor iterators instead of silently swallowing them #19604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions rust/op-reth/crates/trie/src/initialize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,16 @@ macro_rules! define_dup_cursor_iter {
return Some(res);
}

// If no more duplicates, find the next key with values
let Some(Ok((next_key, _))) = self.0.next_no_dup().transpose() else {
// If no more entries, return None
return None;
};

// If found, seek to the first duplicate for this key
return self.0.seek(next_key).transpose();
// If no more duplicates, find the next key with values.
// Use explicit match to propagate MDBX errors
match self.0.next_no_dup() {
Ok(Some((next_key, _))) => {
// Seek to the first duplicate for this key
self.0.seek(next_key).transpose()
}
Ok(None) => None,
Err(e) => Some(Err(e)),
}
}
}
};
Expand Down
Loading