fix(op-reth): propagate MDBX errors in DupSort cursor iterators instead of silently swallowing them#19604
Merged
theochap merged 1 commit intoethereum-optimism:developfrom Mar 18, 2026
Conversation
…ad of silently swallowing them
sebastianst
reviewed
Mar 17, 2026
Member
sebastianst
left a comment
sebastianst
left a comment
There was a problem hiding this comment.
Is there a way to add a regression test for this that would fail without the fix and that emulates intermittent restarts?
Member
|
/ci authorize b1b2633 |
theochap
approved these changes
Mar 18, 2026
Merged
via the queue into
ethereum-optimism:develop
with commit Mar 18, 2026
ec3402a
286 checks passed
ClaytonNorthey92
pushed a commit
to hemilabs/optimism
that referenced
this pull request
Mar 19, 2026
…ad of silently swallowing them (ethereum-optimism#19604)
ClaytonNorthey92
pushed a commit
to hemilabs/optimism
that referenced
this pull request
Mar 23, 2026
…ad of silently swallowing them (ethereum-optimism#19604)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in
define_dup_cursor_iterwhere MDBX errors fromnext_no_dup()are silently treated as end-of-table, potentially truncating data during initialization.If a transient MDBX error occurs mid-iteration, the remaining entries in
HashedStoragesorStoragesTrieare silently skipped. The batch is committed, init may markCompleted, and the next block execution computes a different state root.This could be potential root cause for intermittent hash mismatches observed after multi-step initialization (crash mid-init → restart → first block fails state root check). The intermittent nature aligns with transient I/O errors being position-dependent and rare.
Tests
Pending