fix(ci): handle old/new workspace paths in op-reth-compact-codec job#19124
Closed
devin-ai-integration[bot] wants to merge 1 commit intodevelopfrom
Closed
fix(ci): handle old/new workspace paths in op-reth-compact-codec job#19124devin-ai-integration[bot] wants to merge 1 commit intodevelopfrom
devin-ai-integration[bot] wants to merge 1 commit intodevelopfrom
Conversation
The workspace unification in #19034 moved op-reth from op-reth/ to rust/op-reth/. The compact-codec CI job checks out origin/develop as the base to generate test vectors, but hardcoded the new path which doesn't exist on older commits. This adds path detection to handle both layouts. Co-Authored-By: Kelvin Fichter <kelvinfichter@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19124 +/- ##
===========================================
+ Coverage 75.8% 76.0% +0.2%
===========================================
Files 700 188 -512
Lines 71986 10946 -61040
===========================================
- Hits 54574 8327 -46247
+ Misses 17266 2475 -14791
+ Partials 146 144 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sebastianst
reviewed
Feb 10, 2026
Member
sebastianst
left a comment
There was a problem hiding this comment.
Wondering if we really need this. The next PR that runs this check will already have a git base after the migration to the rust/ folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
op-reth-compact-codecCI job checks outorigin/developas a base to generate compact test vectors for backward compatibility testing. After the workspace unification in #19034 (movedop-reth/→rust/op-reth/), the hardcoded manifest pathrust/op-reth/bin/Cargo.tomldoesn't exist on older develop commits, causing the job to fail withmanifest path does not exist.This adds path detection so the "generate vectors from base" step works regardless of whether the checked-out base has the old (
op-reth/) or new (rust/op-reth/) layout.The "read vectors" step (which runs on the PR branch) is left unchanged since all future branches will use the new path.
Review & Testing Checklist for Human
op-reth/bin/Cargo.toml) and new (rust/op-reth/bin/Cargo.toml) layoutsop-reth-compact-codecCI job on this PR to confirm the fix works end-to-end (this cannot be tested locally)Notes