Skip to content

fix(ci): handle old/new workspace paths in op-reth-compact-codec job#19124

Closed
devin-ai-integration[bot] wants to merge 1 commit intodevelopfrom
devin/1770702679-fix-op-reth-compact-codec-ci
Closed

fix(ci): handle old/new workspace paths in op-reth-compact-codec job#19124
devin-ai-integration[bot] wants to merge 1 commit intodevelopfrom
devin/1770702679-fix-op-reth-compact-codec-ci

Conversation

@devin-ai-integration
Copy link
Contributor

Summary

The op-reth-compact-codec CI job checks out origin/develop as a base to generate compact test vectors for backward compatibility testing. After the workspace unification in #19034 (moved op-reth/rust/op-reth/), the hardcoded manifest path rust/op-reth/bin/Cargo.toml doesn't exist on older develop commits, causing the job to fail with manifest path does not exist.

This adds path detection so the "generate vectors from base" step works regardless of whether the checked-out base has the old (op-reth/) or new (rust/op-reth/) layout.

The "read vectors" step (which runs on the PR branch) is left unchanged since all future branches will use the new path.

Review & Testing Checklist for Human

  • Verify the path detection logic correctly covers both old (op-reth/bin/Cargo.toml) and new (rust/op-reth/bin/Cargo.toml) layouts
  • Confirm the "Read compact vectors on PR branch" step (line 761, unchanged) does not need similar treatment — it runs on the PR branch which should always have the new path
  • Trigger or wait for the op-reth-compact-codec CI job on this PR to confirm the fix works end-to-end (this cannot be tested locally)

Notes

The workspace unification in #19034 moved op-reth from op-reth/ to
rust/op-reth/. The compact-codec CI job checks out origin/develop as
the base to generate test vectors, but hardcoded the new path which
doesn't exist on older commits. This adds path detection to handle
both layouts.

Co-Authored-By: Kelvin Fichter <kelvinfichter@gmail.com>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner February 10, 2026 05:52
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.0%. Comparing base (48a7a09) to head (c2bb6f2).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19124      +/-   ##
===========================================
+ Coverage     75.8%    76.0%    +0.2%     
===========================================
  Files          700      188     -512     
  Lines        71986    10946   -61040     
===========================================
- Hits         54574     8327   -46247     
+ Misses       17266     2475   -14791     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.4% <ø> (-0.9%) ⬇️
contracts-bedrock-tests 81.6% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 517 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we really need this. The next PR that runs this check will already have a git base after the migration to the rust/ folder.

@smartcontracts smartcontracts deleted the devin/1770702679-fix-op-reth-compact-codec-ci branch February 10, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants