Skip to content

feat(rust): unify workspaces#19034

Merged
theochap merged 9 commits intodevelopfrom
theo/unify-workspaces
Feb 10, 2026
Merged

feat(rust): unify workspaces#19034
theochap merged 9 commits intodevelopfrom
theo/unify-workspaces

Conversation

@theochap
Copy link
Member

@theochap theochap commented Jan 30, 2026

Summary

  • Merges all separate Rust workspaces (alloy-op-evm, alloy-op-hardforks, kona, op-alloy, op-reth) into a single unified workspace under rust/
  • Removes per-workspace Cargo.lock, Cargo.toml, deny.toml, rustfmt.toml, and clippy.toml files in favor of shared root-level configs
  • Updates CI configuration (.circleci/) to point to the new workspace structure

Test plan

  • CI passes with the new unified workspace layout
  • All Rust crates build successfully under rust/
  • Existing tests pass in the merged workspace

🤖 Generated with Claude Code

@theochap theochap requested review from a team as code owners January 30, 2026 20:30
@theochap theochap requested review from smartcontracts and removed request for a team January 30, 2026 20:30
@wiz-inc-a178a98b5d
Copy link

wiz-inc-a178a98b5d bot commented Jan 30, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations 1 Medium
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@theochap theochap force-pushed the theo/unify-workspaces branch from 4835948 to 989a02d Compare January 30, 2026 20:32
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.7%. Comparing base (db87881) to head (356de36).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
rust/alloy-op-evm/src/block/canyon.rs 63.1% 7 Missing ⚠️
rust/kona/bin/host/src/interop/handler.rs 0.0% 6 Missing ⚠️
rust/kona/crates/node/engine/src/sync/mod.rs 0.0% 6 Missing ⚠️
...tes/node/engine/src/task_queue/tasks/build/task.rs 0.0% 6 Missing ⚠️
rust/kona/bin/client/src/interop/transition.rs 0.0% 5 Missing ⚠️
...na/crates/node/engine/src/task_queue/tasks/task.rs 0.0% 4 Missing ⚠️
rust/kona/crates/node/peers/src/record.rs 0.0% 4 Missing ⚠️
rust/kona/crates/node/disc/src/driver.rs 0.0% 3 Missing ⚠️
rust/kona/bin/host/src/server.rs 0.0% 2 Missing ⚠️
rust/kona/bin/host/src/single/handler.rs 0.0% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19034      +/-   ##
===========================================
- Coverage     76.3%    75.7%    -0.7%     
===========================================
  Files          188      700     +512     
  Lines        10946    71986   +61040     
===========================================
+ Hits          8360    54495   +46135     
- Misses        2440    17347   +14907     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.4% <ø> (-0.9%) ⬇️
contracts-bedrock-tests 81.6% <ø> (-0.1%) ⬇️
unit 75.6% <50.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rust/alloy-op-evm/src/block/receipt_builder.rs 86.9% <ø> (ø)
rust/alloy-op-evm/src/lib.rs 90.8% <100.0%> (ø)
rust/alloy-op-hardforks/src/lib.rs 93.2% <100.0%> (ø)
rust/kona/bin/client/src/fpvm_evm/factory.rs 0.0% <ø> (ø)
...in/client/src/fpvm_evm/precompiles/bls12_g1_add.rs 100.0% <ø> (ø)
...in/client/src/fpvm_evm/precompiles/bls12_g1_msm.rs 100.0% <ø> (ø)
...in/client/src/fpvm_evm/precompiles/bls12_g2_add.rs 100.0% <ø> (ø)
...in/client/src/fpvm_evm/precompiles/bls12_g2_msm.rs 100.0% <ø> (ø)
...in/client/src/fpvm_evm/precompiles/bls12_map_fp.rs 100.0% <ø> (ø)
...n/client/src/fpvm_evm/precompiles/bls12_map_fp2.rs 100.0% <ø> (ø)
... and 105 more

... and 403 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theochap theochap force-pushed the theo/unify-workspaces branch 7 times, most recently from 5205c06 to 8d9e16b Compare February 2, 2026 16:55
Base automatically changed from theo/update-subtrees to develop February 2, 2026 17:16
@theochap theochap force-pushed the theo/unify-workspaces branch 15 times, most recently from 06fcd15 to 894b8f0 Compare February 3, 2026 00:41
@theochap theochap force-pushed the theo/unify-workspaces branch from 88b3deb to 4e30bef Compare February 4, 2026 18:14
@theochap theochap requested a review from a team as a code owner February 4, 2026 18:14
@theochap theochap force-pushed the theo/unify-workspaces branch 9 times, most recently from 0a3e573 to b48b417 Compare February 9, 2026 18:34
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits before I approve. Still reviewing Cargo.toml.

For reference how I reviewed it: I locally checked out the branch, then restored all **/src/** dirs from the base commit, then let Claude fix builds, ran clippy fix, then reviewed the remaining diff. This showed only code-equivalent changes of clippy warnings. I then also manually reviewed the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants