Skip to content

Comments

fix: only allow enabling permissioned game types in opcmv2 deployment…#19077

Merged
maurelian merged 5 commits intodevelopfrom
sc-feat/opcm2-deploy-opc-games
Feb 6, 2026
Merged

fix: only allow enabling permissioned game types in opcmv2 deployment…#19077
maurelian merged 5 commits intodevelopfrom
sc-feat/opcm2-deploy-opc-games

Conversation

@smartcontracts
Copy link
Contributor

… (#835)

  • fix: only allow permissioned game types in opcmv2 deployment

  • docs: add comment for permissionless games config in deployopchain

  • feat: add isInitialDeployment argument to std validator script

@smartcontracts smartcontracts requested a review from a team as a code owner February 3, 2026 22:47
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.3%. Comparing base (6d0d308) to head (d72a1cc).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #19077     +/-   ##
==========================================
+ Coverage     76.0%    77.3%   +1.2%     
==========================================
  Files          188      133     -55     
  Lines        10943     6916   -4027     
==========================================
- Hits          8324     5347   -2977     
+ Misses        2475     1569    -906     
+ Partials       144        0    -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 77.3% <100.0%> (-4.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...racts-bedrock/src/L1/opcm/OPContractsManagerV2.sol 97.2% <100.0%> (+<0.1%) ⬆️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xiamflux
Copy link
Contributor

LGTM

0xniha and others added 5 commits February 5, 2026 17:32
…#835)

* fix: only allow permissioned game types in opcmv2 deployment

* docs: add comment for permissionless games config in deployopchain

* feat: add isInitialDeployment argument to std validator script
CANNON and CANNON_KONA are intentionally disabled during initial deployment,
so no implementations are registered. The validator correctly flags this as
PLDG-10 and CKDG-10 errors. Update test to expect these errors.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Address review feedback: raise an error instead of silently overwriting
the disputeGameType input. Only PERMISSIONED_CANNON is valid for initial
deployment since no prestate exists for permissionless games.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@smartcontracts smartcontracts force-pushed the sc-feat/opcm2-deploy-opc-games branch from 72b8f91 to d72a1cc Compare February 5, 2026 22:35
@maurelian maurelian added this pull request to the merge queue Feb 6, 2026
Merged via the queue into develop with commit 61c0766 Feb 6, 2026
211 checks passed
@maurelian maurelian deleted the sc-feat/opcm2-deploy-opc-games branch February 6, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants