feat: surface miner nonce too high errors#1906
Merged
mslipper merged 1 commit intoethereum-optimism:developfrom Dec 14, 2021
Merged
feat: surface miner nonce too high errors#1906mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper merged 1 commit intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 2924845 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #1906 +/- ##
========================================
Coverage 72.06% 72.06%
========================================
Files 70 70
Lines 2327 2327
Branches 346 346
========================================
Hits 1677 1677
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mslipper
approved these changes
Dec 14, 2021
This commit exposes the ErrNonceTooHigh at the execution level to external users. Previously the error was mapped to ErrNonceTooLow to match the mempool behavior. As this is a new error, and one not currently exposed in L1, this could be a breaking change for some applications depending on how the error messages are parsed.
mslipper
force-pushed
the
surface-miner-nonce-too-high
branch
from
e313284 to
2924845
Compare
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit exposes the ErrNonceTooHigh at the execution level to
external users. Previously the error was mapped to ErrNonceTooLow to
match the mempool behavior. As this is a new error, and one not
currently exposed in L1, this could be a breaking change for some
applications depending on how the error messages are parsed.
This PR should be merged in conjunction with #1882, so that the errors
are returned at the mempool and miner level simultaneously.
Metadata