Skip to content

Add workaround for old buildx version#19031

Merged
pauldowman merged 3 commits intodevelopfrom
pd/fix-buildx-ci-error
Feb 2, 2026
Merged

Add workaround for old buildx version#19031
pauldowman merged 3 commits intodevelopfrom
pd/fix-buildx-ci-error

Conversation

@pauldowman
Copy link
Contributor

@pauldowman pauldowman commented Jan 30, 2026

Description

#18879 introduced major changes to building prestates, and fixed some CI issues that hadn't been tackled yet witht the kona import to the monorepo. It broke some things that can't easily be found locally.

This is claude's fix for this unknown flag: --allow error in CI.

It looks like docker buildx in this repo's CI may be an old version that doesn't support the --allow flag. The kona prestate build config that was recently imported into the monorepo uses it. This is a workaround. (Claude is pretty sure that older versions which don't support --allow will still work because on older versions filesystem access was allowed by default, so omitting the flag should work correctly. This is hard to test locally so we'll see.

This PR also reverts a workaround that made devstack prefer ws:// connections because HTTP wasn't working properly with supernode. It's safe to revert because supernode now supports HTTP polling.

This is probably not the last build fix for this set of changes since the only way to test is in CI.

Tests

Additional context

Metadata

@pauldowman pauldowman requested review from Inphi and theochap January 30, 2026 18:51
@pauldowman pauldowman requested a review from a team as a code owner January 30, 2026 18:51
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.8%. Comparing base (00b1c81) to head (86f1f93).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19031      +/-   ##
===========================================
+ Coverage     73.0%    76.8%    +3.7%     
===========================================
  Files          188      383     +195     
  Lines        10943    42840   +31897     
===========================================
+ Hits          7993    32902   +24909     
- Misses        2804     9938    +7134     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?
unit 76.8% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 571 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same issue and I was about to work on a fix. Thanks for doing this

@pauldowman pauldowman enabled auto-merge January 30, 2026 20:42
@pauldowman pauldowman added this pull request to the merge queue Feb 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 2, 2026
@pauldowman pauldowman force-pushed the pd/fix-buildx-ci-error branch from b0a0ce6 to 3044d5e Compare February 2, 2026 19:19
@pauldowman
Copy link
Contributor Author

kona e2e tests are failing with "Test killed with quit: ran too long (44m0s)"

@pauldowman pauldowman requested review from a team as code owners February 2, 2026 21:55
@pauldowman pauldowman requested a review from serpixel February 2, 2026 21:55
@pauldowman pauldowman added this pull request to the merge queue Feb 2, 2026
Merged via the queue into develop with commit b76d67e Feb 2, 2026
119 of 120 checks passed
@pauldowman pauldowman deleted the pd/fix-buildx-ci-error branch February 2, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants