Add workaround for old buildx version#19031
Merged
pauldowman merged 3 commits intodevelopfrom Feb 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19031 +/- ##
===========================================
+ Coverage 73.0% 76.8% +3.7%
===========================================
Files 188 383 +195
Lines 10943 42840 +31897
===========================================
+ Hits 7993 32902 +24909
- Misses 2804 9938 +7134
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Inphi
reviewed
Jan 30, 2026
Contributor
Inphi
left a comment
There was a problem hiding this comment.
I ran into the same issue and I was about to work on a fix. Thanks for doing this
Inphi
approved these changes
Jan 30, 2026
theochap
approved these changes
Feb 2, 2026
b0a0ce6 to
3044d5e
Compare
Contributor
Author
|
kona e2e tests are failing with "Test killed with quit: ran too long (44m0s)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#18879 introduced major changes to building prestates, and fixed some CI issues that hadn't been tackled yet witht the kona import to the monorepo. It broke some things that can't easily be found locally.
This is claude's fix for this
unknown flag: --allowerror in CI.It looks like docker buildx in this repo's CI may be an old version that doesn't support the --allow flag. The kona prestate build config that was recently imported into the monorepo uses it. This is a workaround. (Claude is pretty sure that older versions which don't support --allow will still work because on older versions filesystem access was allowed by default, so omitting the flag should work correctly. This is hard to test locally so we'll see.
This PR also reverts a workaround that made devstack prefer ws:// connections because HTTP wasn't working properly with supernode. It's safe to revert because supernode now supports HTTP polling.
This is probably not the last build fix for this set of changes since the only way to test is in CI.
Tests
Additional context
Metadata