Kona: add `reproducible-prestate` target and remove asterisc support by pauldowman · Pull Request #18879 · ethereum-optimism/optimism

pauldowman · 2026-01-20T20:20:32Z

Description

Updates kona prestate builds to use local source instead of cloning from the op-rs/kona repository, adds reproducible-prestate target and removes asterisc support.

Modified cannon-repro.dockerfile to COPY . /kona instead of cloning from GitHub
Removed asterisc support (only cannon is used for kona prestates)
Added just reproducible-prestate target equivalent to op-program's make reproducible-prestate (and make reproducible-prestate at the root builds both op-program and kona prestates)
Removed version.json and the external repo checkout workflow - prestates now build from current commit
Simplified justfile recipes by removing unused build-all, build-kona-host, and checkout-kona targets
Refactored the reproducible-prestate targets to separate the build and the output, so that when make reproducible-prestate is called from the root makefile it builds both Kona and op-program, then outputs the hashes for both of them at the end.

(This ended up doing more than I planned, I just wanted to add a nicer way to build the kona prestates and output the hashes, but ended up needing to stop the justfiles from cloning the op-rs repo, and remove asterisc support.)

Tests

Additional context

Metadata

Fixes #18654
Fixes #18735

codecov · 2026-01-20T20:20:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.6%. Comparing base (b703985) to head (59f317b).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #18879      +/-   ##
===========================================
+ Coverage     76.3%    76.6%    +0.2%     
===========================================
  Files          188      571     +383     
  Lines        10939    53779   +42840     
===========================================
+ Hits          8357    41222   +32865     
- Misses        2436    12413    +9977     
+ Partials       146      144       -2

Flag	Coverage Δ
cannon-go-tests-64	`66.4% <ø> (-0.9%)`	⬇️
contracts-bedrock-tests	`81.7% <ø> (ø)`
unit	`76.7% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.
see 388 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pauldowman · 2026-01-20T21:19:10Z

Looks like I'll need to fix acceptance tests. Moving this back to draft.

ajsutton

We'll need up update the op-program/scripts/build-prestates.sh script as well. It should switch over to using the make reproducible-prestate command. I think we might be lucky that it can keep using the old approach to build prestates from the op-rs/kona repo and just start picking up the kona prestates built from make reproducible-prestate from the monorepo going forward.

Otherwise looks good assuming tests pass.

.circleci/config.yml

op-program/scripts/build-prestates.sh

kona/docker/docker-bake.hcl

op-program/scripts/build-prestates.sh

theochap

Looks good, just a couple of issues to open for follow-ups, good to merge otherwise. Thanks for taking care of it

ops/docker/op-stack-go/Dockerfile

op-program/scripts/build-prestates.sh

pauldowman · 2026-01-29T00:27:30Z

I rebased this onto develop and fixed the CI config merge conflicts. But I can't push it because touching github actions files is not allowed (and docker builds have moved into github actions). I requested an exemption.

falcorocks · 2026-01-29T08:15:46Z

@pauldowman approved

pauldowman · 2026-01-29T14:53:31Z

@ajsutton ready for your re-review.

* feat: add historical proof support for devstack (ethereum-optimism#18853) * historical proof support for devstack * refactored to use `DEVSTACK_L2EL_KIND` and `L2ELOption` * removed op-reth-with-proof from `DEVSTACK_L2EL_KIND` * added todo issue link --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com> * feat(ci): refactor circleci configs (ethereum-optimism#18956) * op-acceptance: Make super dispute games only support super node (ethereum-optimism#18977) * feat(ci): add op-rbuilder and kona-node to docker-bake (ethereum-optimism#18966) * feat(ci): add op-rbuilder and kona-node to docker-bake Add docker-bake.hcl targets for the Rust-based images: - op-rbuilder: uses existing Dockerfile in op-rbuilder/ - kona-node: uses kona's generic app dockerfile Update branches.yaml workflow to build these images in the matrix. Add separate cross-platform check for Rust images since they use ENTRYPOINT instead of CMD. * fix: correct dockerfile path for op-rbuilder target * feat(contracts): add OPCMV2 batch upgrade invariant test (ethereum-optimism#18954) * feat(contracts): add OPCMV2 batch upgrade invariant test Implements test to enforce the invariant that approximately 5 upgrade operations can be executed within a single transaction. - Add BatchUpgrader helper contract for batching 5 sequential upgrades - Add test_batchUpgrade_multipleChains_succeeds() test that: - Deploys 5 separate chains using opcmV2.deploy() - Prepares upgrade inputs for each chain - Executes all 5 upgrades in a single transaction via BatchUpgrader - Verifies all chains upgraded successfully (version and impl checks) This validates that OPCMV2's upgrade mechanism is efficient enough for batch operations across multiple chains. * test(contracts): increase batch test to 15 * fix: correct natspec comment * test(contracts): skip batch upgrade test in coverage mode * Add LibString import and enhance batch upgrade error handling * fix: forge fmt * refactor(test): move batch upgrade test to non-forked test contract The test_batchUpgrade_multipleChains_succeeds test deploys fresh chains and doesn't require forked network state. Moved it to a new test contract OPContractsManagerV2_BatchUpgrade_Test that inherits from OPContractsManagerV2_TestInit instead of the fork-only OPContractsManagerV2_Upgrade_TestInit. Changes: - Created OPContractsManagerV2_BatchUpgrade_Test contract - Moved test from OPContractsManagerV2_Upgrade_Test - Replaced disputeGameFactory queries with makeAddr() calls - Test now runs without FORK_TEST=true requirement * feat: allow Feat* prefix in test validation and rename batch upgrade test Updates test validation to accept middle parts starting with `Feat*` as valid test contract patterns. This allows feature test contracts that don't require corresponding source functions. Also renames OPContractsManagerV2_BatchUpgrade_Test to OPContractsManagerV2_FeatBatchUpgrade_Test to follow the new pattern. * fix: bump retries for opcm registry (ethereum-optimism#18983) Bumps the number of retries for OPCM registry queries to get rid of CI flakes. * feat(txmgr): make blob tip cap mechanism configurable (ethereum-optimism#18981) Add configuration flags to the txmgr to make the blob tip cap mechanism configurable: - `txmgr.blob-tip-cap-dynamic`: Enable/disable using the dynamic blob tip oracle (vs static tip cap) for blob transactions only (default: false) - `txmgr.blob-tip-cap-percentile`: Configure the percentile to use when calculating the suggested blob tip cap (default: 60, range: 1-100) - `txmgr.blob-tip-cap-range`: Configure the number of recent blocks to analyze for the distribution (default: 20) These flags only affect blob transactions. Regular (non-blob) transactions continue to use the standard `txmgr.min-tip-cap` / `txmgr.max-tip-cap` settings. The `txmgr.max-tip-cap` setting is still enforced even when using dynamic blob tip cap. Also adds RPC methods (Get/SetBlobTipCapDynamic) to toggle the setting at runtime. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * feat: have ASR only use IDisputeGame (ethereum-optimism#18945) * feat: have ASR only use IDisputeGame * fix: remove old test * op-acceptance-test: Support creating honest trace accessor for super games. (ethereum-optimism#18978) * Kona: add `reproducible-prestate` target and remove asterisc support (ethereum-optimism#18879) * kona: add reproducible-prestate justfile target * kona: build docker images from local context and remove asterisc support * kona: Remove version.json and simplify justfile * make reproducible-prestate in main Makefile builds kona also * kona: just clean should not remove bin dir * Improve output of main reproducible-prestate make target * Fix kona prestate loading in acceptance tests * kona: build in docker instead of pulling from upstream * Fix location of kona prestate * Update build-prestates.sh * Refactor build-prestates.sh to build both prestate types on all tags * Remove legacy kona versions that aren't in standard-prestates.toml * Remove additional mise install of just * Hardcode rust version for kona reproducible build * build-prestates.sh: only build prestates that match each tag * devstack: Ensure Supernode is exposed in the sysgo system (ethereum-optimism#18986) * devstack: Ensure Supernode is exposed in the sysgo system * review comments * ensure TestCLAdvanceMultiple passes * bump WS read limit to 10MB (ethereum-optimism#19024) * Fix unbound variable error in build-prestates.sh (ethereum-optimism#19026) * feat: semgrep rule preventing initialize without owned check (ethereum-optimism#19002) * feat: semgrep rule preventing initialize without owned check Introduces a new semgrep rule that prevents initialize functions on the L1 side that aren't tagged with the assertOnlyProxyAdminOrProxyAdminOwner assertion. * fix: remove test because semgrep is bad * fix: more semgrep issues * feat: have graphite review storage layout (ethereum-optimism#19004) * feat: have graphite review storage layout Updates the graphite rules so that the robot will review any changes to the storage layout and try to warn developers for unsafe changes. * fix: handle contract deletions or movements * maint: better comments for migration function (ethereum-optimism#19006) Adds a few expanded comments on aspects about the migration function. * test: make sure OPCMv2 can upgrade while paused (ethereum-optimism#19019) Adds a test to confirm that OPCMv2 is able to execute upgrades even while paused. * fix: add code lenght check for ReadSuperchainDeployment and tests (ethereum-optimism#19021) * fix: add code lenght check for ReadSuperchainDeployment and tests * test: fix populate superchain v2 error string * fix: generic revert error in upgrade scripts (ethereum-optimism#19005) * fix: generic revert error in UpgradeOPChain script * fix: generic revert error in UpgradeSuperchainConfig script * fix: get delayedweth from opcm implementations and remove proxy fetch (ethereum-optimism#19003) * Supernode: Interop Acceptance Testing (ethereum-optimism#18970) * Supernode: Interop Acceptance Testing * merge devstack setups * cleanup * Rework Tests * use system provided supernode client ; lint * Update test name * lint ; address ai comment * fix test requires * use superRoot for more tests ; assert pre/post activation more directly * feat: Improve Game Args interface (ethereum-optimism#18952) * feat: Game Args struct instead of raw bytes (#813) * feat: allows a more structured json for gameArgs in upgrade config instead of requiring raw bytes * chore: reorganize structs declarations, move structs out of the EncodedUpgradeInputV2 func * chore: add edge case check for encoded config length * test: add expected encoding values * chore: remove comment * test: update tests * fix: tests (#823) * fix: add revert case for invalid game type (#825) * fix: add revert case for invalid game type * refactor: better error msg --------- Co-authored-by: niha <205694301+0xniha@users.noreply.github.com> --------- Co-authored-by: jagroot <4516586+itschaindev@users.noreply.github.com> Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com> Co-authored-by: theo <80177219+theochap@users.noreply.github.com> Co-authored-by: Adrian Sutton <adrian@oplabs.co> Co-authored-by: Federico <14293929+falcorocks@users.noreply.github.com> Co-authored-by: Maurelian <john@oplabs.co> Co-authored-by: smartcontracts <14298799+smartcontracts@users.noreply.github.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Paul Dowman <paul@pauldowman.com> Co-authored-by: Inphi <mlaw2501@gmail.com> Co-authored-by: Haardik <haardik.haardik@coinbase.com> Co-authored-by: niha <205694301+0xniha@users.noreply.github.com> Co-authored-by: Axel Kingsley <axel.kingsley@gmail.com>

pauldowman requested review from Inphi, ajsutton and theochap January 20, 2026 20:20

pauldowman requested review from a team as code owners January 20, 2026 20:20

pauldowman marked this pull request as draft January 20, 2026 21:19

ajsutton reviewed Jan 20, 2026

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

pauldowman marked this pull request as ready for review January 22, 2026 14:31

pauldowman requested a review from a team as a code owner January 22, 2026 14:31

pauldowman requested a review from serpixel January 22, 2026 14:31

ajsutton reviewed Jan 22, 2026

View reviewed changes

op-program/scripts/build-prestates.sh Outdated Show resolved Hide resolved

theochap reviewed Jan 23, 2026

View reviewed changes

kona/docker/docker-bake.hcl Show resolved Hide resolved

theochap reviewed Jan 23, 2026

View reviewed changes

op-program/scripts/build-prestates.sh Show resolved Hide resolved

theochap approved these changes Jan 23, 2026

View reviewed changes

ajsutton reviewed Jan 26, 2026

View reviewed changes

ops/docker/op-stack-go/Dockerfile Outdated Show resolved Hide resolved

almanax-ai bot reviewed Jan 28, 2026

View reviewed changes

op-program/scripts/build-prestates.sh Show resolved Hide resolved

pauldowman added 11 commits January 28, 2026 16:26

kona: add reproducible-prestate justfile target

ac8e6b1

kona: build docker images from local context and remove asterisc support

b6b8589

kona: Remove version.json and simplify justfile

87847de

make reproducible-prestate in main Makefile builds kona also

5331496

kona: just clean should not remove bin dir

5db5260

Improve output of main reproducible-prestate make target

62d98ef

Fix kona prestate loading in acceptance tests

29d7a01

kona: build in docker instead of pulling from upstream

c05a65b

Fix location of kona prestate

e3c2e3c

Update build-prestates.sh

074e249

Refactor build-prestates.sh to build both prestate types on all tags

cd31590

pauldowman added 4 commits January 28, 2026 16:42

Remove legacy kona versions that aren't in standard-prestates.toml

fea1954

Remove additional mise install of just

b5fa218

Hardcode rust version for kona reproducible build

f00d0b9

build-prestates.sh: only build prestates that match each tag

59f317b

pauldowman force-pushed the pd/kona-reproducible-prestate branch from c3c8d7f to 59f317b Compare January 29, 2026 14:09

ajsutton approved these changes Jan 30, 2026

View reviewed changes

ajsutton added this pull request to the merge queue Jan 30, 2026

Merged via the queue into develop with commit d3fb96d Jan 30, 2026
235 checks passed

ajsutton deleted the pd/kona-reproducible-prestate branch January 30, 2026 02:56

pauldowman mentioned this pull request Jan 30, 2026

Add workaround for old buildx version #19031

Merged

Inphi mentioned this pull request Feb 11, 2026

chore(kona/proofs): remove outdated just recipes once kona's migration is complete #18654

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kona: add `reproducible-prestate` target and remove asterisc support#18879

Kona: add `reproducible-prestate` target and remove asterisc support#18879
ajsutton merged 15 commits intodevelopfrom
pd/kona-reproducible-prestate

pauldowman commented Jan 20, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

pauldowman commented Jan 20, 2026

Uh oh!

ajsutton left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theochap left a comment

Uh oh!

Uh oh!

Uh oh!

pauldowman commented Jan 29, 2026

Uh oh!

falcorocks commented Jan 29, 2026

Uh oh!

pauldowman commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pauldowman commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pauldowman commented Jan 20, 2026

Uh oh!

ajsutton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theochap left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pauldowman commented Jan 29, 2026

Uh oh!

falcorocks commented Jan 29, 2026

Uh oh!

pauldowman commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pauldowman commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 20, 2026 •

edited

Loading