Skip to content

Comments

ops: add check-op-geth-version CI check#18854

Merged
joshklop merged 1 commit intodevelopfrom
joshklop/check-op-geth-version
Jan 19, 2026
Merged

ops: add check-op-geth-version CI check#18854
joshklop merged 1 commit intodevelopfrom
joshklop/check-op-geth-version

Conversation

@joshklop
Copy link
Contributor

@joshklop joshklop commented Jan 19, 2026

Disclaimer: mostly co-written with Opus 4.5.

Add a tool that validates the go.mod replace directive points to a valid op-geth tag.

Runs as a separate CI job so failures are immediately visible in the GitHub UI, which is useful during op-geth merge windows when this check is expected to fail temporarily.

Also updates FindMonorepoRoot to verify the module path matches the optimism monorepo, preventing false positives when run from nested modules.

@joshklop joshklop requested a review from a team as a code owner January 19, 2026 18:19
@joshklop joshklop requested a review from geoknee January 19, 2026 18:19
@wiz-inc-a178a98b5d
Copy link

wiz-inc-a178a98b5d bot commented Jan 19, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 2 Medium
Software Management Finding Software Management Findings -
Total 2 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@joshklop joshklop force-pushed the joshklop/check-op-geth-version branch from d62df31 to 6101ae6 Compare January 19, 2026 18:32
@joshklop joshklop force-pushed the joshklop/check-op-geth-version branch from 6101ae6 to a76add5 Compare January 19, 2026 18:50
@joshklop joshklop enabled auto-merge January 19, 2026 18:51
Add a tool that validates the go.mod replace directive points to a
valid op-geth tag.

Runs as a separate CI job so failures are immediately visible in the
GitHub UI, which is useful during op-geth merge windows when this
check is expected to fail temporarily.

Also updates FindMonorepoRoot to verify the module path matches the
optimism monorepo, preventing false positives when run from nested
modules.
@joshklop joshklop force-pushed the joshklop/check-op-geth-version branch from a76add5 to 89cbde3 Compare January 19, 2026 18:53
@joshklop joshklop added this pull request to the merge queue Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (2a9e41e) to head (89cbde3).
⚠️ Report is 2074 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18854      +/-   ##
===========================================
+ Coverage    73.25%   73.64%   +0.38%     
===========================================
  Files          190      190              
  Lines        11318    11318              
===========================================
+ Hits          8291     8335      +44     
+ Misses        2883     2839      -44     
  Partials       144      144              
Flag Coverage Δ
cannon-go-tests-64 66.42% <ø> (ø)
contracts-bedrock-tests 77.63% <ø> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into develop with commit 186d098 Jan 19, 2026
94 checks passed
@joshklop joshklop deleted the joshklop/check-op-geth-version branch January 19, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants