Skip to content

test(contracts): improve OptimismSuperchainERC20Factory test coverage #18791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smartcontracts merged 2 commits into from
Jan 15, 2026
Merged

test(contracts): improve OptimismSuperchainERC20Factory test coverage #18791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
858935a
refactor(test): rename fuzz tests to follow testFuzz_ naming convention
devin-ai-integration[bot] Jan 15, 2026
644d9d3
test(contracts): add version format validation for OptimismSuperchain…
devin-ai-integration[bot] Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/contracts-bedrock/test/L2/OptimismSuperchainERC20Factory.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { CommonTest } from "test/setup/CommonTest.sol";

// Libraries
import { CREATE3, Bytes32AddressLib } from "@rari-capital/solmate/src/utils/CREATE3.sol";
import { SemverComp } from "src/libraries/SemverComp.sol";

// Target contract
import { IOptimismSuperchainERC20 } from "interfaces/L2/IOptimismSuperchainERC20.sol";
Expand Down Expand Up @@ -42,7 +43,7 @@ abstract contract OptimismSuperchainERC20Factory_TestInit is CommonTest {
/// @notice Tests the `deploy` function of the `OptimismSuperchainERC20Factory` contract.
contract OptimismSuperchainERC20Factory_Deploy_Test is OptimismSuperchainERC20Factory_TestInit {
/// @notice Test that calling `deploy` with valid parameters succeeds.
function test_deploy_succeeds(
function testFuzz_deploy_succeeds(
address _caller,
address _remoteToken,
string memory _name,
Expand Down Expand Up @@ -72,7 +73,7 @@ contract OptimismSuperchainERC20Factory_Deploy_Test is OptimismSuperchainERC20Fa
}

/// @notice Test that calling `deploy` with the same parameters twice reverts.
function test_deploy_sameTwice_reverts(
function testFuzz_deploy_sameTwice_reverts(
address _caller,
address _remoteToken,
string memory _name,
Expand All @@ -92,3 +93,12 @@ contract OptimismSuperchainERC20Factory_Deploy_Test is OptimismSuperchainERC20Fa
l2OptimismSuperchainERC20Factory.deploy(_remoteToken, _name, _symbol, _decimals);
}
}

/// @title OptimismSuperchainERC20Factory_Version_Test
/// @notice Tests the `version` function of the `OptimismSuperchainERC20Factory` contract.
contract OptimismSuperchainERC20Factory_Version_Test is OptimismSuperchainERC20Factory_TestInit {
/// @notice Tests that version returns a valid semver string.
function test_version_validFormat_succeeds() external view {
SemverComp.parse(l2OptimismSuperchainERC20Factory.version());
}
}