Skip to content

Comments

test(contracts): improve OptimismSuperchainERC20Factory test coverage#18791

Merged
smartcontracts merged 2 commits intodevelopfrom
devin/1768460696-improve-optimism-superchain-erc20-factory-tests
Jan 15, 2026
Merged

test(contracts): improve OptimismSuperchainERC20Factory test coverage#18791
smartcontracts merged 2 commits intodevelopfrom
devin/1768460696-improve-optimism-superchain-erc20-factory-tests

Conversation

@devin-ai-integration
Copy link
Contributor

Summary

Improves the OptimismSuperchainERC20Factory test file with two changes:

  1. Naming convention fix: Renamed test_deploy_succeeds and test_deploy_sameTwice_reverts to use the testFuzz_ prefix since they already have fuzzed parameters. This aligns with Foundry conventions.

  2. Version test coverage: Added OptimismSuperchainERC20Factory_Version_Test contract with a test that validates the version string format using SemverComp.parse(), following the established pattern in other test files (e.g., BaseFeeVault.t.sol).

Note: All tests in this file are currently skipped via vm.skip(true) until OptimismSuperchainERC20Factory is re-integrated, so these changes won't execute in CI until then.

Review & Testing Checklist for Human

  • Verify the testFuzz_ naming convention is appropriate for tests with fuzzed parameters
  • Confirm the version test pattern matches other version tests in the codebase

Notes

Last update: 2025-01-15 04:30 ET

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner January 15, 2026 07:11
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.51%. Comparing base (3b496bc) to head (644d9d3).
⚠️ Report is 2025 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18791      +/-   ##
===========================================
+ Coverage    73.85%   77.51%   +3.65%     
===========================================
  Files          190      135      -55     
  Lines        11318     7288    -4030     
===========================================
- Hits          8359     5649    -2710     
+ Misses        2813     1639    -1174     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 77.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smartcontracts smartcontracts added this pull request to the merge queue Jan 15, 2026
Merged via the queue into develop with commit b0d16f7 Jan 15, 2026
93 checks passed
@smartcontracts smartcontracts deleted the devin/1768460696-improve-optimism-superchain-erc20-factory-tests branch January 15, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants