test(contracts): improve OptimismSuperchainERC20Factory test coverage#18791
Merged
smartcontracts merged 2 commits intodevelopfrom Jan 15, 2026
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18791 +/- ##
===========================================
+ Coverage 73.85% 77.51% +3.65%
===========================================
Files 190 135 -55
Lines 11318 7288 -4030
===========================================
- Hits 8359 5649 -2710
+ Misses 2813 1639 -1174
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
smartcontracts
approved these changes
Jan 15, 2026
maurelian
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the
OptimismSuperchainERC20Factorytest file with two changes:Naming convention fix: Renamed
test_deploy_succeedsandtest_deploy_sameTwice_revertsto use thetestFuzz_prefix since they already have fuzzed parameters. This aligns with Foundry conventions.Version test coverage: Added
OptimismSuperchainERC20Factory_Version_Testcontract with a test that validates the version string format usingSemverComp.parse(), following the established pattern in other test files (e.g.,BaseFeeVault.t.sol).Note: All tests in this file are currently skipped via
vm.skip(true)untilOptimismSuperchainERC20Factoryis re-integrated, so these changes won't execute in CI until then.Review & Testing Checklist for Human
testFuzz_naming convention is appropriate for tests with fuzzed parametersNotes
Last update: 2025-01-15 04:30 ET