Skip to content

Comments

all: Remove cannon-kona dgv2 feature flags (#18208)#18588

Merged
Inphi merged 2 commits intoproposal/op-contracts/v6.0.0from
inphi/remove-featureflag
Dec 15, 2025
Merged

all: Remove cannon-kona dgv2 feature flags (#18208)#18588
Inphi merged 2 commits intoproposal/op-contracts/v6.0.0from
inphi/remove-featureflag

Conversation

@Inphi
Copy link
Contributor

@Inphi Inphi commented Dec 12, 2025

Cherry picking #18208 to the v6 proposal branch

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.34%. Comparing base (e3dcc7d) to head (aae210b).
⚠️ Report is 5 commits behind head on proposal/op-contracts/v6.0.0.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           proposal/op-contracts/v6.0.0   #18588      +/-   ##
================================================================
- Coverage                         75.09%   71.34%   -3.75%     
================================================================
  Files                               185      185              
  Lines                             11001    10914      -87     
================================================================
- Hits                               8261     7787     -474     
- Misses                             2596     2983     +387     
  Partials                            144      144              
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (ø)
contracts-bedrock-tests 74.13% <100.00%> (-5.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 89.48% <100.00%> (-5.62%) ⬇️
...ock/src/L1/OPContractsManagerStandardValidator.sol 97.22% <100.00%> (-2.78%) ⬇️
...es/contracts-bedrock/src/libraries/DevFeatures.sol 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cherry-pick(all): Remove cannon-kona dgv2 feature flags
@Inphi Inphi force-pushed the inphi/remove-featureflag branch from 72326af to 14adcf4 Compare December 12, 2025 05:31
@Inphi Inphi added the force-use-fresh-artifacts Disable artifact `latest` fallback and force fresh compilation (requires manual CI rerun) label Dec 12, 2025
@Inphi Inphi marked this pull request as ready for review December 12, 2025 16:06
@Inphi Inphi requested review from a team as code owners December 12, 2025 16:06
@pauldowman
Copy link
Contributor

Is aae210b also on develop? I don't see it.

@Inphi
Copy link
Contributor Author

Inphi commented Dec 12, 2025

Is aae210b also on develop? I don't see it.

Nay. The commit is a subset of changes in 337766844c54e322e86dc6de076e5a70943ba7d4 required to pass CI.

@pauldowman
Copy link
Contributor

Nay. The commit is a subset of changes in 337766844c54e322e86dc6de076e5a70943ba7d4 required to pass CI.

So those changes are on develop. 👍

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@Inphi Inphi merged commit d6aa14e into proposal/op-contracts/v6.0.0 Dec 15, 2025
80 checks passed
@Inphi Inphi deleted the inphi/remove-featureflag branch December 15, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-use-fresh-artifacts Disable artifact `latest` fallback and force fresh compilation (requires manual CI rerun)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants