Skip to content

feat: update whitelist task for multiple addresses#1851

Merged
tynes merged 1 commit intodevelopfrom
sc/multi-whitelist-support
Dec 6, 2021
Merged

feat: update whitelist task for multiple addresses#1851
tynes merged 1 commit intodevelopfrom
sc/multi-whitelist-support

Conversation

@smartcontracts
Copy link
Contributor

Description
Modifies the whitelist script to add support for whitelisting multiple addresses. Also adds support for adding or removing addresses from the whitelist instead of just adding.

Metadata

  • Fixes ENG-1647

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2021

⚠️ No Changeset found

Latest commit: 5d0d7ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #1851 (5d0d7ec) into develop (b9ee2d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1851   +/-   ##
========================================
  Coverage    71.99%   71.99%           
========================================
  Files           70       70           
  Lines         2321     2321           
  Branches       346      346           
========================================
  Hits          1671     1671           
  Misses         650      650           
Flag Coverage Δ
batch-submitter 62.07% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ee2d7...5d0d7ec. Read the comment docs.

@smartcontracts
Copy link
Contributor Author

Doesn't impact the build, shouldn't need a changeset.

@smartcontracts smartcontracts requested review from K-Ho and tynes December 3, 2021 19:44
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but untested. Looking to @K-Ho to verify that it works. Would it be helpful to log the tx hashes at the end?

@tynes tynes merged commit dc3586a into develop Dec 6, 2021
@tynes tynes deleted the sc/multi-whitelist-support branch December 6, 2021 20:26
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Alternative version of #1851, which keeps the `BinaryHeap` priority
queue and achieves the same goal of not starving the engine actor
control loop.
theochap pushed a commit that referenced this pull request Jan 14, 2026
## Overview

Alternative version of #1851, which keeps the `BinaryHeap` priority
queue and achieves the same goal of not starving the engine actor
control loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants