Skip to content

docker: update node version to 16#1836

Merged
tynes merged 2 commits intodevelopfrom
docker/node-version
Dec 4, 2021
Merged

docker: update node version to 16#1836
tynes merged 2 commits intodevelopfrom
docker/node-version

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Dec 1, 2021

Description
node.js version 16 is currently the lts version
so this commit updates each of the dockerfiles to
use node version 16

node.js version 16 is currently the lts version
so this commit updates each of the dockerfiles to
use node version 16
@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021

🦋 Changeset detected

Latest commit: 0ab37fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/integration-tests Patch
@eth-optimism/builder Patch
@eth-optimism/batch-submitter Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tynes tynes changed the title Docker/node version docker: update node version to 16 Dec 1, 2021
@tynes tynes requested a review from mslipper December 1, 2021 01:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #1836 (0ab37fc) into develop (0fb44b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1836   +/-   ##
========================================
  Coverage    71.99%   71.99%           
========================================
  Files           70       70           
  Lines         2321     2321           
  Branches       346      346           
========================================
  Hits          1671     1671           
  Misses         650      650           
Flag Coverage Δ
batch-submitter 62.07% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb44b3...0ab37fc. Read the comment docs.

@smartcontracts
Copy link
Contributor

Going to double check that we don't have any packages that rely on 14.

@smartcontracts
Copy link
Contributor

Nvm I don't think we do. Approving...

Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tynes tynes merged commit 4f82200 into develop Dec 4, 2021
@tynes tynes deleted the docker/node-version branch December 4, 2021 00:28
@elenadimitrova
Copy link
Contributor

We are on version 14 in the .nvmrc file though. Do we also need to up that @smartcontracts ?

theochap pushed a commit that referenced this pull request Dec 10, 2025
Closes #1681

Things that are still left:

- Call relevant DB functions on event notification
- Check subscription with actual node
- Fallback to HTTP polling using `PullEvents` if subscription does not
work

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants