Skip to content

Fix proxyd release workflow#1829

Merged
tynes merged 2 commits intodevelopfrom
bwilson/fix-proxyd-release-workflow
Nov 30, 2021
Merged

Fix proxyd release workflow#1829
tynes merged 2 commits intodevelopfrom
bwilson/fix-proxyd-release-workflow

Conversation

@optimisticben
Copy link
Contributor

Description
Fix proxyd release workflow

Metadata

@optimisticben optimisticben requested a review from tynes November 30, 2021 14:45
@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2021

🦋 Changeset detected

Latest commit: 34fcb27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/proxyd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work labels Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #1829 (34fcb27) into develop (d42ab8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1829   +/-   ##
========================================
  Coverage    71.99%   71.99%           
========================================
  Files           70       70           
  Lines         2321     2321           
  Branches       346      346           
========================================
  Hits          1671     1671           
  Misses         650      650           
Flag Coverage Δ
batch-submitter 62.07% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.64% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42ab8c...34fcb27. Read the comment docs.

@mslipper
Copy link
Collaborator

mslipper commented Nov 30, 2021

Has this been broken since proxyd was first created, or is this new?

@optimisticben
Copy link
Contributor Author

Has this been broken since proxyd was first created, or is this new?

I made the same fixes on the canary workflow and have been using that image so far.

@mslipper
Copy link
Collaborator

mslipper commented Nov 30, 2021

Ah, gotcha. Thanks for fixing this, sorry I introduced the issue in the first place.

@tynes tynes merged commit 1ae21d8 into develop Nov 30, 2021
@tynes tynes deleted the bwilson/fix-proxyd-release-workflow branch November 30, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proxyd docker publishing failing

4 participants