Skip to content

gas-oracle: fix the gas price metric#1821

Merged
tynes merged 1 commit intodevelopfrom
fix/gpo-metrics
Nov 29, 2021
Merged

gas-oracle: fix the gas price metric#1821
tynes merged 1 commit intodevelopfrom
fix/gpo-metrics

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Nov 29, 2021

Description

The gas-price metric was renamed to gas_price
as using a - is invalid syntax in a prometheus metric.

Fixes #1819

The `gas-price` metric was renamed to `gas_price`
as using a `-` is invalid syntax in a prometheus metric.

Fixes #1819
@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2021

🦋 Changeset detected

Latest commit: e4067d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/gas-oracle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@optimisticben optimisticben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@tynes tynes merged commit 5546b1f into develop Nov 29, 2021
@tynes tynes deleted the fix/gpo-metrics branch November 29, 2021 20:21
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Adds an action to free up some disk space prior to the kurtosis run.
Seeing this job fail quite a bit due to running out of disk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gas Oracle metric format incompatible with Prometheus

2 participants