feat: surface low-level sequencer execution errors, fix itest flakes#1816
Merged
mslipper merged 3 commits intoethereum-optimism:developfrom Dec 9, 2021
Merged
Conversation
🦋 Changeset detectedLatest commit: c62c486 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cfromknecht
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1816 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 70 70
Lines 2321 2321
Branches 346 346
========================================
Hits 1671 1671
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Collaborator
|
Mind walking us through these changes during tomorrow's infra sync? |
cfromknecht
force-pushed
the
surface-sequencer-execution-errors
branch
from
35bdcb3 to
6e7edc6
Compare
This was referenced Dec 7, 2021
Closed
cfromknecht
force-pushed
the
surface-sequencer-execution-errors
branch
2 times, most recently
from
1006f78 to
7f0c739
Compare
cfromknecht
force-pushed
the
surface-sequencer-execution-errors
branch
from
7f0c739 to
e55b93c
Compare
cfromknecht
force-pushed
the
surface-sequencer-execution-errors
branch
from
e55b93c to
c62c486
Compare
Contributor
Author
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Forwards derivation reset events to the engine. In the case of the `HoloceneActivation` reset, the reset can be handled internal to the pipeline without informing the engine. Additionally, adds functionality to block the derivation actor while it is waiting for a signal to be sent back. This will prevent it from attempting to advance while the engine is resetting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After surfacing the errors as part of the deadlock fix, the itests now exhibit a flake caused by these unexpected errors being returned. Internally, the harness detects and reattempts expected errors (currently rejected at the txpool level), however, the specific lower-level execution errors are still not surfaced. To fix the itests, we need to bubble up the specific execution errors (rather than the generic "Cannot commit transaction in miner") to the rpc caller, which will allow the test harness to proceed as usual.
Builds on:
Metadata