op-acceptance-tests: harden the BPO blob base fee calculation test#17953
Merged
joshklop merged 1 commit intojoshklop/osaka-cleanupfrom Oct 28, 2025
Merged
op-acceptance-tests: harden the BPO blob base fee calculation test#17953joshklop merged 1 commit intojoshklop/osaka-cleanupfrom
joshklop merged 1 commit intojoshklop/osaka-cleanupfrom
Conversation
joshklop
requested review from
geoknee and
janjakubnanista
and removed request for
a team and
janjakubnanista
joshklop
force-pushed
the
joshklop/adjust-bpo-test
branch
2 times, most recently
from
8f026d6 to
f0adedf
Compare
joshklop
force-pushed
the
joshklop/osaka-cleanup
branch
from
97e3e1b to
c0829ab
Compare
joshklop
force-pushed
the
joshklop/adjust-bpo-test
branch
from
f0adedf to
81a3209
Compare
joshklop
force-pushed
the
joshklop/adjust-bpo-test
branch
from
81a3209 to
f8bee19
Compare
joshklop
force-pushed
the
joshklop/adjust-bpo-test
branch
6 times, most recently
from
c3abe09 to
3d20286
Compare
joshklop
force-pushed
the
joshklop/osaka-cleanup
branch
from
c0829ab to
7d341d4
Compare
geoknee
approved these changes
Oct 27, 2025
Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae is complicated, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment)
joshklop
force-pushed
the
joshklop/adjust-bpo-test
branch
from
3d20286 to
3398f16
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
…st (#17944) * split out helpers and initialization to a separate file * fix comment in mise.toml * rename osaka test * rename to fusaka * txplan: support non-cell proof blob txs * also verify the l1 blob base fee in the l1 block contract * optimization #17529 (comment) * op-acceptance-tests: harden the BPO blob base fee calculation test (#17953) Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae is complicated, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment) * add log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.