op-acceptance-tests: various improvements to the Fusaka acceptance test#17944
Merged
op-acceptance-tests: various improvements to the Fusaka acceptance test#17944
Conversation
joshklop
requested review from
ajsutton and
geoknee
and removed request for
ajsutton
Contributor
Author
|
Hopefully this is straightforward enough to review quickly. I'm leaving two comments on the previous PR for separate follow-ups:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17944 +/- ##
===========================================
+ Coverage 74.76% 81.23% +6.46%
===========================================
Files 175 120 -55
Lines 11238 6453 -4785
===========================================
- Hits 8402 5242 -3160
+ Misses 2692 1211 -1481
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
joshklop
force-pushed
the
joshklop/osaka-cleanup
branch
from
97e3e1b to
c0829ab
Compare
joshklop
force-pushed
the
joshklop/osaka-cleanup
branch
from
c0829ab to
7d341d4
Compare
geoknee
approved these changes
Oct 27, 2025
…17953) Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae is complicated, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #17529, which merged with nits due to time pressure.