feat: clean up and comment aliasing utils#1791
Merged
smartcontracts merged 1 commit intodevelopfrom Nov 23, 2021
Merged
Conversation
🦋 Changeset detectedLatest commit: 584cbc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #1791 +/- ##
===========================================
+ Coverage 71.95% 72.00% +0.04%
===========================================
Files 67 70 +3
Lines 2182 2318 +136
Branches 328 345 +17
===========================================
+ Hits 1570 1669 +99
- Misses 612 649 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cfromknecht
approved these changes
Nov 23, 2021
Contributor
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
LGTM, great comments 🎸
smartcontracts
force-pushed
the
sc/alias-util-comments
branch
from
afb6679 to
584cbc2
Compare
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Tiny nit - updates the block insertion log such that the hash is rendered without quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Very minor update to
core-utils, just updating the comments attached to the aliasing utils and movesbnToAddressinto its own file meant to hold whatever otherbnutilities we expect to build.