Skip to content

Fix deadlock on invalid txs#1783

Closed
mslipper wants to merge 5 commits intoethereum-optimism:developfrom
mslipper:bugfix/fix-deadlock
Closed

Fix deadlock on invalid txs#1783
mslipper wants to merge 5 commits intoethereum-optimism:developfrom
mslipper:bugfix/fix-deadlock

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

  • Fixes a bug that causes Geth to deadlock if transactions pass the policy checks but fail in the miner.
  • Fixes a bug that causes Geth to mine empty blocks, and returns a proper error to users.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 19, 2021

🦋 Changeset detected

Latest commit: 227851d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #1783 (f68e845) into develop (d59341a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1783   +/-   ##
========================================
  Coverage    71.81%   71.81%           
========================================
  Files           69       69           
  Lines         2303     2303           
  Branches       344      344           
========================================
  Hits          1654     1654           
  Misses         649      649           
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontracts/contracts/L1/verification/BondManager.sol 100.00% <0.00%> (ø)
...tracts/contracts/L1/messaging/L1StandardBridge.sol 97.05% <0.00%> (ø)
...racts/contracts/L1/rollup/StateCommitmentChain.sol 87.50% <0.00%> (ø)
...acts/contracts/L1/rollup/ChainStorageContainer.sol 70.00% <0.00%> (ø)
.../contracts/L1/messaging/L1CrossDomainMessenger.sol 96.77% <0.00%> (ø)
.../contracts/L1/rollup/CanonicalTransactionChain.sol 86.66% <0.00%> (ø)
.../contracts/libraries/bridge/CrossDomainEnabled.sol 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59341a...f68e845. Read the comment docs.

- Fixes a bug that causes Geth to deadlock if transactions pass the policy checks but fail in the miner.
- Fixes a bug that causes Geth to mine empty blocks, and returns a proper error to users.
@mslipper mslipper force-pushed the bugfix/fix-deadlock branch from c655f01 to d991791 Compare November 19, 2021 18:11
Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cannon Area: cannon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants