Skip to content

feat: rewrite generate-artifacts in ts#1770

Merged
tynes merged 1 commit intodevelopfrom
sc/gen-artifacts-ts
Nov 19, 2021
Merged

feat: rewrite generate-artifacts in ts#1770
tynes merged 1 commit intodevelopfrom
sc/gen-artifacts-ts

Conversation

@smartcontracts
Copy link
Contributor

Description
Simple PR, rewrites the generate-artifacts.js script in TypeScript since we shouldn't have random JS files all over the place.

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2021

⚠️ No Changeset found

Latest commit: 8d02466

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #1770 (efa3e9b) into develop (b882d8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1770   +/-   ##
========================================
  Coverage    71.81%   71.81%           
========================================
  Files           69       69           
  Lines         2303     2303           
  Branches       344      344           
========================================
  Hits          1654     1654           
  Misses         649      649           
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b882d8c...efa3e9b. Read the comment docs.


/**
* Script for automatically generating a file which has a series of `require` statements for
* importing JSON contract artifacts. We do this to preserve browser compatibility.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relies on fs so unsure what you mean by this statement of preserving browser compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script generates a file and the generated file is designed to preserve browser compat

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tynes tynes force-pushed the sc/gen-artifacts-ts branch from efa3e9b to 8d02466 Compare November 19, 2021 22:22
@tynes tynes merged commit 705d567 into develop Nov 19, 2021
@tynes tynes deleted the sc/gen-artifacts-ts branch November 19, 2021 22:25
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants