Skip to content

maintenance: remove event types from core utils#1765

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/remove-events-from-core-utils
Nov 23, 2021
Merged

maintenance: remove event types from core utils#1765
smartcontracts merged 1 commit intodevelopfrom
sc/remove-events-from-core-utils

Conversation

@smartcontracts
Copy link
Contributor

Description
Updates typechain so that we can remove the exported event types from @eth-optimism/core-utils.

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2021

⚠️ No Changeset found

Latest commit: c47bbb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-core-utils Area: packages/core-utils labels Nov 13, 2021
@smartcontracts
Copy link
Contributor Author

This changes three packages:

  1. @eth-optimism/core-utils: removed event types
  2. @eth-optimism/contracts: updated to latest typechain version so that better types are exported
  3. @eth-optimism/data-transport-layer: uses new event types exported by the contracts package

I think @eth-optimism/data-transport-layer can pretty safely be a patch release. contracts and core-utils might have to be a minor release since this changes the API.

@smartcontracts smartcontracts force-pushed the sc/remove-events-from-core-utils branch from 9ae6550 to 92619d1 Compare November 13, 2021 02:17
@@ -1,38 +0,0 @@
import { ethers } from 'ethers'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main value of this PR is being able to delete this file

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #1765 (92619d1) into develop (b882d8c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1765      +/-   ##
===========================================
- Coverage    71.81%   71.80%   -0.02%     
===========================================
  Files           69       69              
  Lines         2303     2302       -1     
  Branches       344      344              
===========================================
- Hits          1654     1653       -1     
  Misses         649      649              
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.41% <ø> (-0.13%) ⬇️
data-transport-layer 38.23% <100.00%> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-utils/src/index.ts 100.00% <ø> (ø)
.../l1-ingestion/handlers/sequencer-batch-appended.ts 21.53% <ø> (ø)
...ices/l1-ingestion/handlers/state-batch-appended.ts 68.18% <ø> (ø)
...ices/l1-ingestion/handlers/transaction-enqueued.ts 53.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b882d8c...92619d1. Read the comment docs.

@smartcontracts smartcontracts requested a review from tynes November 17, 2021 16:26
@K-Ho K-Ho requested a review from cfromknecht November 23, 2021 17:14
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍 The integration tests failed however. Looks like a flake, probably just needs to be restarted

@smartcontracts smartcontracts force-pushed the sc/remove-events-from-core-utils branch 2 times, most recently from e6955eb to 4fd063a Compare November 23, 2021 18:38
@smartcontracts smartcontracts force-pushed the sc/remove-events-from-core-utils branch from 4fd063a to c47bbb8 Compare November 23, 2021 19:13
@smartcontracts smartcontracts merged commit b4d9d53 into develop Nov 23, 2021
@smartcontracts smartcontracts deleted the sc/remove-events-from-core-utils branch November 23, 2021 19:53
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants