Skip to content

fix: remove branch restrictions for some workflows#1760

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/workflow-all-branches
Nov 24, 2021
Merged

fix: remove branch restrictions for some workflows#1760
smartcontracts merged 1 commit intodevelopfrom
sc/workflow-all-branches

Conversation

@smartcontracts
Copy link
Contributor

Description
Removes branch restrictions for all testing/linting workflows that still had them so that we're running these when working on any base branch.

Metadata

  • Fixes ENG-1541

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2021

⚠️ No Changeset found

Latest commit: ac71b98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work labels Nov 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #1760 (ac71b98) into develop (68cd04f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1760   +/-   ##
========================================
  Coverage    72.00%   72.00%           
========================================
  Files           70       70           
  Lines         2318     2318           
  Branches       345      345           
========================================
  Hits          1669     1669           
  Misses         649      649           
Flag Coverage Δ
batch-submitter 62.07% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 57.50% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cd04f...ac71b98. Read the comment docs.

Copy link
Contributor

@optimisticben optimisticben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@K-Ho K-Ho requested a review from karlfloersch November 23, 2021 17:13
Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I haven't removed the branches option before, but this gives me confidence this workflow change should work.

@smartcontracts smartcontracts force-pushed the sc/workflow-all-branches branch from 18f4fb1 to ac71b98 Compare November 24, 2021 17:00
@smartcontracts smartcontracts merged commit 3f055d6 into develop Nov 24, 2021
@smartcontracts smartcontracts deleted the sc/workflow-all-branches branch November 24, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants