Skip to content

chore: Update yarn.lock#1748

Closed
maurelian wants to merge 1 commit intodevelopfrom
maurelian/run-yarn
Closed

chore: Update yarn.lock#1748
maurelian wants to merge 1 commit intodevelopfrom
maurelian/run-yarn

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Nov 11, 2021

Running yarn on develop resulted in this diff.

I'm not actually sure it's what we'd expect tho...

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2021

⚠️ No Changeset found

Latest commit: f096c7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

yarn.lock Outdated
Copy link
Contributor Author

@maurelian maurelian Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're removing 0.6.0 and keeping 0.5.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems off there... I think we need to find where 0.5.1 is and bump it manually. This could be due to removing ^ in the package.jsons

Copy link
Contributor Author

@maurelian maurelian Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is smock doing this somehow? ie. the second result has the same semver as what's in the lock file.
image

@maurelian
Copy link
Contributor Author

maurelian commented Nov 11, 2021

The commit I just force pushed was created using yarn upgrade instead of just yarn. But I don't think that's the right move either. Going to try rm -f yarn.lock && yarn.
Edit, nope, that didn't work.

@maurelian
Copy link
Contributor Author

maurelian commented Nov 11, 2021

OK, I'm pretty lost as to what the issue is here, feels like a bug with yarn v1.

We have three different PRs trying 3 different things now:

  1. This one, which is generated by yarn upgrade. It has a large diff in yarn.lock, but not the expected version of core-utils.
  2. @annieke's fix: run yarn on develop #1749, which is generated by yarn, but only has core-utils@^0.5.1.
  3. Another PR (which I put in my own repo just to keep this one clean), it does appear to install the correct version, but requires upgrading to yarn v2.
  4. There's no PR for it, but I also tried rm -f yarn.lock && yarn locally, which results in the same diff as fix: run yarn on develop #1749.

@smartcontracts smartcontracts deleted the maurelian/run-yarn branch November 11, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants